From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754165AbaE1TZs (ORCPT ); Wed, 28 May 2014 15:25:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39413 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751338AbaE1TZq (ORCPT ); Wed, 28 May 2014 15:25:46 -0400 Date: Wed, 28 May 2014 12:29:21 -0700 From: Greg Kroah-Hartman To: Joe Perches Cc: Kukjin Kim , Jingoo Han , Doug Anderson , Jiri Slaby , linux-serial@vger.kernel.org, LKML Subject: Re: [PATCH] serial: samsung: Neaten dbg uses Message-ID: <20140528192921.GA32241@kroah.com> References: <1400619950.26709.39.camel@joe-AO725> <20140528192713.GA24902@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140528192713.GA24902@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 28, 2014 at 12:27:13PM -0700, Greg Kroah-Hartman wrote: > On Tue, May 20, 2014 at 02:05:50PM -0700, Joe Perches wrote: > > Add format and argument checking and fix misuses in the dbg macro. > > > > Add __printf > > Use %pR for resource > > Add #include guard to samsung.h > > Move static functions from .h to .c > > Use vscnprintf instead of length unguarded vsprintf > > > > Signed-off-by: Joe Perches > > --- > > > > compiled (no warnings)/untested. > > > > drivers/tty/serial/samsung.c | 35 +++++++++++++++++++++++++++++------ > > drivers/tty/serial/samsung.h | 23 +++-------------------- > > 2 files changed, 32 insertions(+), 26 deletions(-) > > > > diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c > > index 1f5505e..3293377 100644 > > --- a/drivers/tty/serial/samsung.c > > +++ b/drivers/tty/serial/samsung.c > > @@ -53,6 +53,29 @@ > > > > #include "samsung.h" > > > > +#if defined(CONFIG_SERIAL_SAMSUNG_DEBUG) && \ > > + defined(CONFIG_DEBUG_LL) && \ > > + !defined(MODULE) > > + > > +extern void printascii(const char *); > > + > > +__printf(1, 2) > > +static void dbg(const char *fmt, ...) > > +{ > > + va_list va; > > + char buff[256]; > > + > > + va_start(va, fmt); > > + vscnprintf(buff, sizeof(buf), fmt, va); > > + va_end(va); > > + > > + printascii(buff); > > +} > > + > > +#else > > +#define dbg(fmt, ...) do { if (0) no_printk(fmt, ##__VA_ARGS__); } while (0) > > +#endif > > Ick, what a mess. I'll take this, but I think I'll just convert this to > dev_dbg() instead of dealing with a config option mess... Hm, nevermind, in looking at this further, it's hard to debug a driver with a console command if the driver is the console itself :) I'll just leave this as-is after applying this patch. greg k-h