Re: [PATCHSET 00/27] perf tools: Add support to accumulate hist periods (v11)

[Jiri Olsa <jolsa@redhat.com>]

On Thu, May 29, 2014 at 12:58:03PM +0900, Namhyung Kim wrote:
> Hello,
> 
> This is a new attempt to implement cumulative hist period report.
> This work begins from Arun's SORT_INCLUSIVE patch [1] but I completely
> rewrote it from scratch.
> 
> This patchset basically adds period in a sample to every node in the
> callchain.  A hist_entry now has an additional fields to keep the
> cumulative period if --children option is given on perf report.
> 
> I changed the option as a separate --children and added a new
> "Children" column (and renamed the default "Overhead" column into
> "Self").  The output will be sorted by children (cumulative) overhead
> for now.  It also adds 'overhead_children' field to -F/--fields option
> to be selected by user and it'll show you "N/A" if the cumulation is
> not supported (due to missing callchain).
> 
> I added Tested-by from Rodrigo Campos since this version is basically
> rebase of previous series + bugfix.  But it still needs to be tested
> more intensively IMHO.  Also note that, this will change default
> behavior of perf report/top if callchain is recorded, so might confuse
> old users.  Let's see how many of them come to shout. :)  I think we
> need to merge Jiri's TUI column header patch at least.
> 
> 
>  * changes in v11:
>   - factor out hists__inc_nr_samples  (Jiri)
>   - remove unrelated change  (Jiri)
>   - disable accumulation on branch or mem mode
>   - slightly refactor hist_iter code

apart from that comment I sent, I think it's ready to go in

thanks,
jirka