From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757734AbaE2PuP (ORCPT ); Thu, 29 May 2014 11:50:15 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39593 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757422AbaE2PuM (ORCPT ); Thu, 29 May 2014 11:50:12 -0400 Date: Thu, 29 May 2014 08:53:49 -0700 From: Greg Kroah-Hartman To: Satish Patel Cc: Rob Herring , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-omap , "devicetree@vger.kernel.org" , Rob Landley , Tony Lindgren , Grant Likely , Rob Herring Subject: Re: [PATCH v3 3/5] char: ti-usim: Add driver for USIM module on AM43xx Message-ID: <20140529155349.GD32214@kroah.com> References: <1401267437-22489-1-git-send-email-satish.patel@ti.com> <1401267437-22489-4-git-send-email-satish.patel@ti.com> <53870671.6080601@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53870671.6080601@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 29, 2014 at 03:35:37PM +0530, Satish Patel wrote: > >>+enum usim_card_mode { > >>+ USIM_CARD_MODE_ASYNC = 0, /* asynchronous mode */ > >>+ USIM_CARD_MODE_SYNC_TYPE1, /* synchronous mode: Type 1 */ > >>+ USIM_CARD_MODE_SYNC_TYPE2, /* synchronous mode: Type 2 */ > >>+ USIM_CARD_MODE_SYNC_OTHER, /* Any other synchronous type */ > >>+}; > >>+struct usim_data { > >>+ int slot; > >>+ int rxexplen; > >>+ int txlen; > >>+ unsigned char apdu[256]; > >>+}; You need to use the proper variable types for a structure that is going to cross the user/kernel boundry in an ioctl :(