From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: eric.ernst@linux.intel.com
Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
mark.gross@intel.com
Subject: Re: [PATCH 1/1] PINCTRL: Warn if direct IRQ GPIO set to output
Date: Fri, 30 May 2014 11:48:22 +0300 [thread overview]
Message-ID: <20140530084822.GC1645@lahna.fi.intel.com> (raw)
In-Reply-To: <1401218804-77997-1-git-send-email-eric.ernst@linux.intel.com>
On Tue, May 27, 2014 at 12:26:44PM -0700, eric.ernst@linux.intel.com wrote:
> From: Eric Ernst <eric.ernst@linux.intel.com>
>
> For Baytrail, you should never set a GPIO set to direct_irq
> to output mode. When direct_irq_en is set for a GPIO, it is
> tied directly to an APIC internally, and making the pad output
> does not make any sense. Assert a WARN() in the event this happens.
Can't we just clear that flag when the GPIO is requested? Or is this
something which can't be done at this point?
next prev parent reply other threads:[~2014-05-30 8:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 19:26 [PATCH 1/1] PINCTRL: Warn if direct IRQ GPIO set to output eric.ernst
2014-05-29 13:44 ` Linus Walleij
2014-05-29 21:57 ` eric ernst
2014-05-30 8:48 ` Mika Westerberg [this message]
2014-06-02 18:35 ` eric ernst
2014-06-02 19:13 ` Mika Westerberg
2014-06-02 19:14 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530084822.GC1645@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=eric.ernst@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.gross@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox