* [PATCH] extcon: Set parent device of extcon device using prameter of devm_extcon_dev_allocate
@ 2014-05-30 1:41 Chanwoo Choi
2014-05-30 9:36 ` Charles Keepax
0 siblings, 1 reply; 4+ messages in thread
From: Chanwoo Choi @ 2014-05-30 1:41 UTC (permalink / raw)
To: linux-kernel
Cc: myungjoo.ham, kyungmin.park, Chanwoo Choi, Charles Keepax,
Mark Brown, Graeme Gregory, Kishon Vijay Abraham I,
Krzysztof Kozlowski
This patch set the parent device of extcon device using first parameter of
devm_extco_dev_allocate() to remove duplicate code on all of extcon provider
drivers.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Reported-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Graeme Gregory <gg@slimlogic.co.uk>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/extcon/extcon-adc-jack.c | 1 -
drivers/extcon/extcon-arizona.c | 1 -
drivers/extcon/extcon-class.c | 2 ++
drivers/extcon/extcon-gpio.c | 1 -
drivers/extcon/extcon-max77693.c | 1 -
drivers/extcon/extcon-max8997.c | 1 -
drivers/extcon/extcon-palmas.c | 1 -
7 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c
index e18f95b..d860229 100644
--- a/drivers/extcon/extcon-adc-jack.c
+++ b/drivers/extcon/extcon-adc-jack.c
@@ -112,7 +112,6 @@ static int adc_jack_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "failed to allocate extcon device\n");
return -ENOMEM;
}
- data->edev->dev.parent = &pdev->dev;
data->edev->name = pdata->name;
/* Check the length of array and set num_cables */
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index c634796..d9bd3c3 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -1165,7 +1165,6 @@ static int arizona_extcon_probe(struct platform_device *pdev)
return -ENOMEM;
}
info->edev->name = "Headset Jack";
- info->edev->dev.parent = arizona->dev;
ret = devm_extcon_dev_register(&pdev->dev, info->edev);
if (ret < 0) {
diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c
index 18d42c0..4c2f2c5 100644
--- a/drivers/extcon/extcon-class.c
+++ b/drivers/extcon/extcon-class.c
@@ -645,6 +645,8 @@ struct extcon_dev *devm_extcon_dev_allocate(struct device *dev,
return edev;
}
+ edev->dev.parent = dev;
+
*ptr = edev;
devres_add(dev, ptr);
diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
index 645b283..5b7ec27 100644
--- a/drivers/extcon/extcon-gpio.c
+++ b/drivers/extcon/extcon-gpio.c
@@ -105,7 +105,6 @@ static int gpio_extcon_probe(struct platform_device *pdev)
return -ENOMEM;
}
extcon_data->edev->name = pdata->name;
- extcon_data->edev->dev.parent = &pdev->dev;
extcon_data->gpio = pdata->gpio;
extcon_data->gpio_active_low = pdata->gpio_active_low;
diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
index 2c7c3e1..e9ec6ae 100644
--- a/drivers/extcon/extcon-max77693.c
+++ b/drivers/extcon/extcon-max77693.c
@@ -1183,7 +1183,6 @@ static int max77693_muic_probe(struct platform_device *pdev)
goto err_irq;
}
info->edev->name = DEV_NAME;
- info->edev->dev.parent = &pdev->dev;
ret = devm_extcon_dev_register(&pdev->dev, info->edev);
if (ret) {
diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
index d9f7f1b..d22c379 100644
--- a/drivers/extcon/extcon-max8997.c
+++ b/drivers/extcon/extcon-max8997.c
@@ -706,7 +706,6 @@ static int max8997_muic_probe(struct platform_device *pdev)
goto err_irq;
}
info->edev->name = DEV_NAME;
- info->edev->dev.parent = &pdev->dev;
ret = devm_extcon_dev_register(&pdev->dev, info->edev);
if (ret) {
diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
index 5efa96c..230e122 100644
--- a/drivers/extcon/extcon-palmas.c
+++ b/drivers/extcon/extcon-palmas.c
@@ -194,7 +194,6 @@ static int palmas_usb_probe(struct platform_device *pdev)
return -ENOMEM;
}
palmas_usb->edev->name = kstrdup(node->name, GFP_KERNEL);
- palmas_usb->edev->dev.parent = palmas_usb->dev;
palmas_usb->edev->mutually_exclusive = mutually_exclusive;
status = devm_extcon_dev_register(&pdev->dev, palmas_usb->edev);
--
1.8.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] extcon: Set parent device of extcon device using prameter of devm_extcon_dev_allocate
2014-05-30 1:41 [PATCH] extcon: Set parent device of extcon device using prameter of devm_extcon_dev_allocate Chanwoo Choi
@ 2014-05-30 9:36 ` Charles Keepax
2014-05-30 9:49 ` Chanwoo Choi
0 siblings, 1 reply; 4+ messages in thread
From: Charles Keepax @ 2014-05-30 9:36 UTC (permalink / raw)
To: Chanwoo Choi
Cc: linux-kernel, myungjoo.ham, kyungmin.park, Mark Brown,
Graeme Gregory, Kishon Vijay Abraham I, Krzysztof Kozlowski
On Fri, May 30, 2014 at 10:41:39AM +0900, Chanwoo Choi wrote:
> This patch set the parent device of extcon device using first parameter of
> devm_extco_dev_allocate() to remove duplicate code on all of extcon provider
> drivers.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Reported-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Graeme Gregory <gg@slimlogic.co.uk>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/extcon/extcon-adc-jack.c | 1 -
> drivers/extcon/extcon-arizona.c | 1 -
> drivers/extcon/extcon-class.c | 2 ++
> drivers/extcon/extcon-gpio.c | 1 -
> drivers/extcon/extcon-max77693.c | 1 -
> drivers/extcon/extcon-max8997.c | 1 -
> drivers/extcon/extcon-palmas.c | 1 -
> 7 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c
> index e18f95b..d860229 100644
> --- a/drivers/extcon/extcon-adc-jack.c
> +++ b/drivers/extcon/extcon-adc-jack.c
> @@ -112,7 +112,6 @@ static int adc_jack_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "failed to allocate extcon device\n");
> return -ENOMEM;
> }
> - data->edev->dev.parent = &pdev->dev;
> data->edev->name = pdata->name;
>
> /* Check the length of array and set num_cables */
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index c634796..d9bd3c3 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -1165,7 +1165,6 @@ static int arizona_extcon_probe(struct platform_device *pdev)
> return -ENOMEM;
> }
> info->edev->name = "Headset Jack";
> - info->edev->dev.parent = arizona->dev;
>
> ret = devm_extcon_dev_register(&pdev->dev, info->edev);
This changes the parent device for the Arizona stuff, I don't
think this is a problem but I should probably test here first.
Thanks,
Charles
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] extcon: Set parent device of extcon device using prameter of devm_extcon_dev_allocate
2014-05-30 9:36 ` Charles Keepax
@ 2014-05-30 9:49 ` Chanwoo Choi
2014-05-30 12:43 ` Charles Keepax
0 siblings, 1 reply; 4+ messages in thread
From: Chanwoo Choi @ 2014-05-30 9:49 UTC (permalink / raw)
To: Charles Keepax
Cc: linux-kernel, myungjoo.ham, kyungmin.park, Mark Brown,
Graeme Gregory, Kishon Vijay Abraham I, Krzysztof Kozlowski
Hi Charles,
On 05/30/2014 06:36 PM, Charles Keepax wrote:
> On Fri, May 30, 2014 at 10:41:39AM +0900, Chanwoo Choi wrote:
>> This patch set the parent device of extcon device using first parameter of
>> devm_extco_dev_allocate() to remove duplicate code on all of extcon provider
>> drivers.
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Reported-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
>> Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
>> Cc: Mark Brown <broonie@kernel.org>
>> Cc: Graeme Gregory <gg@slimlogic.co.uk>
>> Cc: Kishon Vijay Abraham I <kishon@ti.com>
>> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>> drivers/extcon/extcon-adc-jack.c | 1 -
>> drivers/extcon/extcon-arizona.c | 1 -
>> drivers/extcon/extcon-class.c | 2 ++
>> drivers/extcon/extcon-gpio.c | 1 -
>> drivers/extcon/extcon-max77693.c | 1 -
>> drivers/extcon/extcon-max8997.c | 1 -
>> drivers/extcon/extcon-palmas.c | 1 -
>> 7 files changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c
>> index e18f95b..d860229 100644
>> --- a/drivers/extcon/extcon-adc-jack.c
>> +++ b/drivers/extcon/extcon-adc-jack.c
>> @@ -112,7 +112,6 @@ static int adc_jack_probe(struct platform_device *pdev)
>> dev_err(&pdev->dev, "failed to allocate extcon device\n");
>> return -ENOMEM;
>> }
>> - data->edev->dev.parent = &pdev->dev;
>> data->edev->name = pdata->name;
>>
>> /* Check the length of array and set num_cables */
>> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
>> index c634796..d9bd3c3 100644
>> --- a/drivers/extcon/extcon-arizona.c
>> +++ b/drivers/extcon/extcon-arizona.c
>> @@ -1165,7 +1165,6 @@ static int arizona_extcon_probe(struct platform_device *pdev)
>> return -ENOMEM;
>> }
>> info->edev->name = "Headset Jack";
>> - info->edev->dev.parent = arizona->dev;
>>
>> ret = devm_extcon_dev_register(&pdev->dev, info->edev);
>
> This changes the parent device for the Arizona stuff, I don't
> think this is a problem but I should probably test here first.
OK, Let me know about test result.
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] extcon: Set parent device of extcon device using prameter of devm_extcon_dev_allocate
2014-05-30 9:49 ` Chanwoo Choi
@ 2014-05-30 12:43 ` Charles Keepax
0 siblings, 0 replies; 4+ messages in thread
From: Charles Keepax @ 2014-05-30 12:43 UTC (permalink / raw)
To: Chanwoo Choi
Cc: linux-kernel, myungjoo.ham, kyungmin.park, Mark Brown,
Graeme Gregory, Kishon Vijay Abraham I, Krzysztof Kozlowski
On Fri, May 30, 2014 at 06:49:03PM +0900, Chanwoo Choi wrote:
> Hi Charles,
>
> OK, Let me know about test result.
>
> Thanks,
> Chanwoo Choi
Yeah that seems to work fine here. For the Arizona bit you can
add:
Tested-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-30 12:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-30 1:41 [PATCH] extcon: Set parent device of extcon device using prameter of devm_extcon_dev_allocate Chanwoo Choi
2014-05-30 9:36 ` Charles Keepax
2014-05-30 9:49 ` Chanwoo Choi
2014-05-30 12:43 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox