From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755771AbaE3Mzv (ORCPT ); Fri, 30 May 2014 08:55:51 -0400 Received: from mail-ie0-f182.google.com ([209.85.223.182]:61300 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751529AbaE3Mzu (ORCPT ); Fri, 30 May 2014 08:55:50 -0400 Date: Fri, 30 May 2014 13:55:43 +0100 From: Lee Jones To: Wolfram Sang Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, grant.likely@linaro.org, linus.walleij@linaro.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH] i2c: Make I2C ID tables non-mandatory for DT'ed and/or ACPI'ed devices Message-ID: <20140530125543.GA29731@lee--X1> References: <1401452797-29521-1-git-send-email-lee.jones@linaro.org> <1401452797-29521-2-git-send-email-lee.jones@linaro.org> <20140530123656.GC2742@katana> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140530123656.GC2742@katana> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 May 2014, Wolfram Sang wrote: > On Fri, May 30, 2014 at 01:26:36PM +0100, Lee Jones wrote: > > Currently the I2C framework insists on devices supplying an I2C ID > > table. Many of the devices which do so unnecessarily adding quite a > > few wasted lines to kernel code. This patch allows drivers a means > > to 'not' supply the aforementioned table and match on either DT > > and/or ACPI match tables instead. > > > > Signed-off-by: Lee Jones > > Sadly, it is not that easy... > > > + /* > > + * An I2C ID table is not madatory, if and only if, a suitable Device > > + * Tree and/or ACPI match table entry is supplied for the probing > > + * device. > > + */ > > That means we end up with drivers which cannot be used for run-time > instantiation via the 'new_device'-file in sysfs. I don't like that. Would you mind explaining that a little please? And perhaps point me to the code? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog