Re: [PATCH] toosl/perf: convert "==" into "="

Re: [PATCH] toosl/perf: convert "==" into "="

[Arnaldo Carvalho de Melo]

[-- Attachment #1: Type: text/plain, Size: 923 bytes --]

Em Fri, May 30, 2014 at 05:37:29PM +0200, Jiri Olsa escreveu:
> On Fri, May 30, 2014 at 12:20:11PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, May 30, 2014 at 02:44:46PM +0200, Jean Delvare escreveu:
> > > I don't have anything to do with this, I'm not the author of the code
> > > nor the maintainer and I don't know anything about it. Arnaldo Carvalho
> > > de Melo is the right person to handle this bug.
> > 
> > Jiri,

> > 	Please take this patch, you can stick my:

> > Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>

> sure, but I dont see the patch on the lkml.. any chance of resend?
 
> I guess I could dig the patch from above.. if you confirm it's
> the only change ;-)

Hey, no need to go to such great lenghts, submitters must try and make
it easier to maintainers! :-)

Find it attached, zhangdianfang, please send it as an attachment next
time, also please CC lkml as well.

Thanks,

- Arnaldo

[-- Attachment #2: ui_browser.patch --]
[-- Type: text/plain, Size: 4011 bytes --]

>From acme  Thu May 29 22:31:47 2014
Delivered-To: arnaldo.melo@gmail.com
Received: from gmail-imap.l.google.com [74.125.131.109]
	by zoo.ghostprotocols.net with IMAP (fetchmail-6.3.26)
	for <acme@localhost> (single-drop); Thu, 29 May 2014 22:31:47 -0300 (BRT)
Received: by 10.170.63.135 with SMTP id f129csp73227ykf; Thu, 29 May 2014
 17:54:50 -0700 (PDT)
X-Received: by 10.66.148.98 with SMTP id tr2mr13825805pab.33.1401411289441;
 Thu, 29 May 2014 17:54:49 -0700 (PDT)
Return-Path: <zhangdianfang@huawei.com>
Received: from mail.kernel.org (mail.kernel.org. [198.145.19.201]) by
 mx.google.com with ESMTP id we6si3163030pac.143.2014.05.29.17.54.49 for
 <arnaldo.melo@gmail.com>; Thu, 29 May 2014 17:54:49 -0700 (PDT)
Received-SPF: softfail (google.com: domain of transitioning
 zhangdianfang@huawei.com does not designate 198.145.19.201 as permitted
 sender) client-ip=198.145.19.201;
Authentication-Results: mx.google.com; spf=softfail (google.com: domain of
 transitioning zhangdianfang@huawei.com does not designate 198.145.19.201 as
 permitted sender) smtp.mail=zhangdianfang@huawei.com
Received: by mail.kernel.org (Postfix) id E533120142; Fri, 30 May 2014
 00:54:48 +0000 (UTC)
Delivered-To: acme@kernel.org
Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org
 (Postfix) with ESMTP id 3937E2035E for <acme@kernel.org>; Fri, 30 May 2014
 00:54:48 +0000 (UTC)
Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [119.145.14.66])
 (using TLSv1 with cipher DES-CBC3-SHA (168/168 bits)) (No client certificate
 requested) by mail.kernel.org (Postfix) with ESMTPS id 88E0D20142 for
 <acme@kernel.org>; Fri, 30 May 2014 00:54:43 +0000 (UTC)
Received: from 172.24.2.119 (EHLO szxeml207-edg.china.huawei.com)
 ([172.24.2.119]) by szxrg03-dlp.huawei.com (MOS 4.4.3-GA FastPath queued)
 with ESMTP id API05293; Fri, 30 May 2014 08:54:04 +0800 (CST)
Received: from SZXEML422-HUB.china.huawei.com (10.82.67.161) by
 szxeml207-edg.china.huawei.com (172.24.2.56) with Microsoft SMTP Server (TLS)
 id 14.3.158.1; Fri, 30 May 2014 08:54:02 +0800
Received: from [127.0.0.1] (10.177.27.190) by szxeml422-hub.china.huawei.com
 (10.82.67.161) with Microsoft SMTP Server id 14.3.158.1; Fri, 30 May 2014
 08:53:59 +0800
Message-ID: <5387D6A6.20703@huawei.com>
Date: Fri, 30 May 2014 08:53:58 +0800
From: zhangdianfang <zhangdianfang@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130509
 Thunderbird/17.0.6
MIME-Version: 1.0
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
CC: Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>, Arnaldo
 Carvalho de Melo <acme@kernel.org>, David Binderman <dcb314@hotmail.com>,
 Jean Delvare <jdelvare@suse.de>
Subject: [PATCH] toosl/perf: convert "==" into "="
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.27.190]
X-CFilter-Loop: Reflected
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,
 RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org
X-Virus-Scanned: ClamAV using ClamSMTP
Status: RO

convert "==" into "="

Bug description: https://bugzilla.kernel.org/show_bug.cgi?id=76751

Cc: Jean Delvare <jdelvare@suse.de>
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Dianfang Zhang <zhangdianfang@huawei.com>
---
 tools/perf/ui/browser.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
index d11541d..3ccf6e1 100644
--- a/tools/perf/ui/browser.c
+++ b/tools/perf/ui/browser.c
@@ -194,7 +194,7 @@ int ui_browser__warning(struct ui_browser *browser, int timeout,
 		ui_helpline__vpush(format, args);
 		va_end(args);
 	} else {
-		while ((key == ui__question_window("Warning!", text,
+		while ((key = ui__question_window("Warning!", text,
 						   "Press any key...",
 						   timeout)) == K_RESIZE)
 			ui_browser__handle_resize(browser);
-- 
1.7.1

Re: [PATCH] toosl/perf: convert "==" into "="

[Peter Zijlstra]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

On Fri, May 30, 2014 at 12:47:09PM -0300, Arnaldo Carvalho de Melo wrote:
> Find it attached, zhangdianfang, please send it as an attachment next
> time, also please CC lkml as well.

And here I thought attachments were frowned upon ;-)

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] toosl/perf: convert "==" into "="

[Namhyung Kim]

Hi Arnaldo,

On Fri, 30 May 2014 12:47:09 -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, May 30, 2014 at 05:37:29PM +0200, Jiri Olsa escreveu:
>> On Fri, May 30, 2014 at 12:20:11PM -0300, Arnaldo Carvalho de Melo wrote:
>> > Em Fri, May 30, 2014 at 02:44:46PM +0200, Jean Delvare escreveu:
>> > > I don't have anything to do with this, I'm not the author of the code
>> > > nor the maintainer and I don't know anything about it. Arnaldo Carvalho
>> > > de Melo is the right person to handle this bug.
>> > 
>> > Jiri,
>
>> > 	Please take this patch, you can stick my:
>
>> > Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
>> sure, but I dont see the patch on the lkml.. any chance of resend?
>  
>> I guess I could dig the patch from above.. if you confirm it's
>> the only change ;-)
>
> Hey, no need to go to such great lenghts, submitters must try and make
> it easier to maintainers! :-)
>
> Find it attached, zhangdianfang, please send it as an attachment next
> time, also please CC lkml as well.


[SNIP]
>
> convert "==" into "="
>
> Bug description: https://bugzilla.kernel.org/show_bug.cgi?id=76751
>
> Cc: Jean Delvare <jdelvare@suse.de>
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Dianfang Zhang <zhangdianfang@huawei.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


> ---
>  tools/perf/ui/browser.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
> index d11541d..3ccf6e1 100644
> --- a/tools/perf/ui/browser.c
> +++ b/tools/perf/ui/browser.c
> @@ -194,7 +194,7 @@ int ui_browser__warning(struct ui_browser *browser, int timeout,
>  		ui_helpline__vpush(format, args);
>  		va_end(args);
>  	} else {
> -		while ((key == ui__question_window("Warning!", text,
> +		while ((key = ui__question_window("Warning!", text,
>  						   "Press any key...",
>  						   timeout)) == K_RESIZE)
>  			ui_browser__handle_resize(browser);

[tip:perf/core] perf tools: Fix "==" into "=" in ui_browser__warning assignment

[tip-bot for zhangdianfang]

Commit-ID:  7f3e508ee1e6cc1b5865edcbf04a14a76ff1534c
Gitweb:     http://git.kernel.org/tip/7f3e508ee1e6cc1b5865edcbf04a14a76ff1534c
Author:     zhangdianfang <zhangdianfang@huawei.com>
AuthorDate: Fri, 30 May 2014 08:53:58 +0800
Committer:  Jiri Olsa <jolsa@kernel.org>
CommitDate: Tue, 3 Jun 2014 21:34:48 +0200

perf tools: Fix "==" into "=" in ui_browser__warning assignment

Convert "==" into "=" in ui_browser__warning assignment.

Bug description: https://bugzilla.kernel.org/show_bug.cgi?id=76751

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Dianfang Zhang <zhangdianfang@huawei.com>
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jean Delvare <jdelvare@suse.de>
Link: http://lkml.kernel.org/r/20140530154709.GC1202@kernel.org
[ changed the changelog a bit ]
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/ui/browser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
index d11541d..3ccf6e1 100644
--- a/tools/perf/ui/browser.c
+++ b/tools/perf/ui/browser.c
@@ -194,7 +194,7 @@ int ui_browser__warning(struct ui_browser *browser, int timeout,
 		ui_helpline__vpush(format, args);
 		va_end(args);
 	} else {
-		while ((key == ui__question_window("Warning!", text,
+		while ((key = ui__question_window("Warning!", text,
 						   "Press any key...",
 						   timeout)) == K_RESIZE)
 			ui_browser__handle_resize(browser);