* [PATCH] clk: versatile: free icst on error return
@ 2014-04-12 17:59 Colin King
2014-04-22 13:04 ` Linus Walleij
2014-05-31 0:08 ` Mike Turquette
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2014-04-12 17:59 UTC (permalink / raw)
To: Mike Turquette, Linus Walleij, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
commit a183da63 introduced a new error return path that does
not kfree icst if the kmemdup of desc->params fails.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/clk/versatile/clk-icst.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/versatile/clk-icst.c b/drivers/clk/versatile/clk-icst.c
index a820b0c..eb3a1e4 100644
--- a/drivers/clk/versatile/clk-icst.c
+++ b/drivers/clk/versatile/clk-icst.c
@@ -140,6 +140,7 @@ struct clk *icst_clk_register(struct device *dev,
pclone = kmemdup(desc->params, sizeof(*pclone), GFP_KERNEL);
if (!pclone) {
+ kfree(icst);
pr_err("could not clone ICST params\n");
return ERR_PTR(-ENOMEM);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clk: versatile: free icst on error return
2014-04-12 17:59 [PATCH] clk: versatile: free icst on error return Colin King
@ 2014-04-22 13:04 ` Linus Walleij
2014-05-31 0:08 ` Mike Turquette
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2014-04-22 13:04 UTC (permalink / raw)
To: Colin King; +Cc: Mike Turquette, linux-kernel@vger.kernel.org
On Sat, Apr 12, 2014 at 7:59 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> commit a183da63 introduced a new error return path that does
> not kfree icst if the kmemdup of desc->params fails.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: versatile: free icst on error return
2014-04-12 17:59 [PATCH] clk: versatile: free icst on error return Colin King
2014-04-22 13:04 ` Linus Walleij
@ 2014-05-31 0:08 ` Mike Turquette
1 sibling, 0 replies; 3+ messages in thread
From: Mike Turquette @ 2014-05-31 0:08 UTC (permalink / raw)
To: Colin King, Linus Walleij, linux-kernel
Quoting Colin King (2014-04-12 10:59:14)
> From: Colin Ian King <colin.king@canonical.com>
>
> commit a183da63 introduced a new error return path that does
> not kfree icst if the kmemdup of desc->params fails.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to clk-next.
Thanks,
Mike
> ---
> drivers/clk/versatile/clk-icst.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/versatile/clk-icst.c b/drivers/clk/versatile/clk-icst.c
> index a820b0c..eb3a1e4 100644
> --- a/drivers/clk/versatile/clk-icst.c
> +++ b/drivers/clk/versatile/clk-icst.c
> @@ -140,6 +140,7 @@ struct clk *icst_clk_register(struct device *dev,
>
> pclone = kmemdup(desc->params, sizeof(*pclone), GFP_KERNEL);
> if (!pclone) {
> + kfree(icst);
> pr_err("could not clone ICST params\n");
> return ERR_PTR(-ENOMEM);
> }
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-31 0:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-12 17:59 [PATCH] clk: versatile: free icst on error return Colin King
2014-04-22 13:04 ` Linus Walleij
2014-05-31 0:08 ` Mike Turquette
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox