From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daniel Dressler <danieru.dressler@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
serban.constantinescu@arm.com, linux-kernel@vger.kernel.org,
arve@android.com, john.stultz@linaro.org, prtvar.b@gmail.com
Subject: Re: [PATCH] Staging: android: binder: Fix over-80-char lines
Date: Sat, 31 May 2014 09:51:20 +0300 [thread overview]
Message-ID: <20140531065120.GK15585@mwanda> (raw)
In-Reply-To: <1401510680-13991-1-git-send-email-danieru.dressler@gmail.com>
What Neil said.
On Fri, May 30, 2014 at 10:31:20PM -0600, Daniel Dressler wrote:
> From: danieru <danieru.dressler@gmail.com>
This is wrong and we also get your name and email address from the
email headers so leave this line out.
>
> Following Greg Kroah-Hartman's newbie guide to hacking
> the linux kernel this patch addresses only coding style
> issues.
>
> Binder still has many too-long lines but I'm worried
> doing too much work in a single patch is unfair to the
> reviewers. So this patch address 20% of the file's
> issues.
>
> There is one change to take notice of: it merges two if
> statement's conditionals together. Then it removes a
> redundant else clause.
Thanks for pointing this out, but the else statement wasn't redundant.
Your change introduces a bug.
Your patch doesn't apply. You need to work against linux-next.
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-31 6:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-31 4:31 [PATCH] Staging: android: binder: Fix over-80-char lines Daniel Dressler
2014-05-31 5:42 ` NeilBrown
2014-05-31 6:51 ` Dan Carpenter [this message]
2014-05-31 17:25 ` Daniel Dressler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140531065120.GK15585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arve@android.com \
--cc=danieru.dressler@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prtvar.b@gmail.com \
--cc=serban.constantinescu@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox