From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752501AbaFBHjX (ORCPT ); Mon, 2 Jun 2014 03:39:23 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:40605 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751442AbaFBHjW (ORCPT ); Mon, 2 Jun 2014 03:39:22 -0400 Date: Mon, 2 Jun 2014 10:39:04 +0300 From: Dan Carpenter To: Rickard Strandqvist Cc: Greg Kroah-Hartman , Xenia Ragiadakou , Peter P Waskiewicz Jr , Ana Rey , Teodora Baluta , Andrea Merello , devel@driverdev.osuosl.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] staging: rtl8192u: r8192U_core.c: Cleaning up uninitialized variables Message-ID: <20140602073904.GQ17724@mwanda> References: <1401629315-18843-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <20140601203703.GO17724@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 01, 2014 at 11:05:39PM +0200, Rickard Strandqvist wrote: > Hi Dan > > I agree, this looks strange. > Have been looking for a while in history with, to see if the code has > been removed. I start my search using cppcheck for over three months > ago. > But could not find anything. Sorry about that :-( > > But I'll make a patch that completely removes testing variable then instead? Yes. Btw, what do the cppcheck error messages for this look like anyway? regards, dan carpenter