From: "Antoine Ténart" <antoine.tenart@free-electrons.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Antoine Ténart" <antoine.tenart@free-electrons.com>,
sebastian.hesselbarth@gmail.com,
thomas.petazzoni@free-electrons.com, zmxu@marvell.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
alexandre.belloni@free-electrons.com, jszhang@marvell.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] ARM: berlin: add SMP support
Date: Mon, 2 Jun 2014 11:35:03 +0200 [thread overview]
Message-ID: <20140602093503.GA24919@kwain> (raw)
In-Reply-To: <20140602092913.GA933@n2100.arm.linux.org.uk>
On Mon, Jun 02, 2014 at 10:29:13AM +0100, Russell King - ARM Linux wrote:
> On Mon, Jun 02, 2014 at 11:21:02AM +0200, Antoine Ténart wrote:
> > diff --git a/arch/arm/mach-berlin/Kconfig b/arch/arm/mach-berlin/Kconfig
> > index d3c5f14dc142..e3733692f67a 100644
> > --- a/arch/arm/mach-berlin/Kconfig
> > +++ b/arch/arm/mach-berlin/Kconfig
> > @@ -4,6 +4,7 @@ config ARCH_BERLIN
> > select GENERIC_IRQ_CHIP
> > select DW_APB_ICTL
> > select DW_APB_TIMER_OF
> > + select SMP
>
> Please don't add selects of symbols which aren't absolutely necessary.
>
> Since this has been merged without SMP support and presumably works without
> SMP support, it would appear that SMP support is not mandatory for the
> platform to work.
It can work without SMP, I'll remove this.
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-06-02 9:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 9:21 [PATCH 0/5] ARM: Berlin: SMP support Antoine Ténart
2014-06-02 9:21 ` [PATCH 1/5] ARM: berlin: add " Antoine Ténart
2014-06-02 9:29 ` Russell King - ARM Linux
2014-06-02 9:35 ` Antoine Ténart [this message]
2014-06-02 9:47 ` Andrew Lunn
2014-06-02 10:00 ` Antoine Ténart
2014-06-02 10:03 ` Andrew Lunn
2014-06-02 10:27 ` Antoine Ténart
2014-06-03 6:19 ` Jisheng Zhang
2014-06-03 7:50 ` Andrew Lunn
2014-06-03 8:02 ` Jisheng Zhang
2014-06-03 6:31 ` Jisheng Zhang
2014-06-03 7:10 ` Antoine Ténart
2014-06-03 7:18 ` Jisheng Zhang
2014-06-02 9:21 ` [PATCH 2/5] Documentation: bindings: document the Marvell Berlin enable-method Antoine Ténart
2014-06-02 10:44 ` Mark Rutland
2014-06-02 9:21 ` [PATCH 3/5] Documentation: bindings: add the Berlin CPU control doc Antoine Ténart
2014-06-02 9:21 ` [PATCH 4/5] ARM: dts: berlin: add SMP related nodes and properties for BG2 Antoine Ténart
2014-06-02 9:21 ` [PATCH 5/5] ARM: dts: berlin: add SMP related nodes and properties for BG2Q Antoine Ténart
2014-06-02 9:35 ` [PATCH 0/5] ARM: Berlin: SMP support Andrew Lunn
2014-06-02 9:44 ` Antoine Ténart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602093503.GA24919@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox