From: Dan Carpenter <dan.carpenter@oracle.com>
To: John Church <sleeveroller@gmail.com>
Cc: gregkh@linuxfoundation.org, lisa@xenapiadmin.com,
bergwolf@gmail.com, andreas.dilger@intel.com,
oleg.drokin@intel.com, doug.s.oucharek@intel.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: fix sparse warnings for undeclared symbols
Date: Mon, 2 Jun 2014 15:19:18 +0300 [thread overview]
Message-ID: <20140602121918.GZ15585@mwanda> (raw)
In-Reply-To: <1401710628-3690-1-git-send-email-sleeveroller@gmail.com>
On Mon, Jun 02, 2014 at 01:03:48PM +0100, John Church wrote:
> This patch fixes the following sparse warnings for drivers/staging/lustre/lnet/lnet/router.c:
>
> router.c:139:1: warning: symbol 'lnet_ni_notify_locked' was not declared. Should it be static?
> router.c:277:1: warning: symbol 'lnet_add_route_to_rnet' was not declared. Should it be static?
>
Why not just make them static? They don't seem to be used outside of
that file. What am I missing?
regards,
dan carpenter
next prev parent reply other threads:[~2014-06-02 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 12:03 [PATCH] staging: lustre: fix sparse warnings for undeclared symbols John Church
2014-06-02 12:19 ` Dan Carpenter [this message]
2014-06-02 13:14 ` John Church
-- strict thread matches above, loose matches on Subject: below --
2014-06-02 13:31 John Church
2014-06-16 10:44 [PATCH] staging: lustre: Fix " Scott Weir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602121918.GZ15585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andreas.dilger@intel.com \
--cc=bergwolf@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=doug.s.oucharek@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lisa@xenapiadmin.com \
--cc=oleg.drokin@intel.com \
--cc=sleeveroller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox