From: Tony Lindgren <tony@atomide.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: FanWu <fwu@marvell.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"swarren@nvidia.com" <swarren@nvidia.com>,
Chao Xie <cxie4@marvell.com>, Yilu Mao <ylmao@marvell.com>,
Ning Jiang <njiang1@marvell.com>,
Xiaofan Tian <tianxf@marvell.com>, Fangsuo Wu <fswu@marvell.com>
Subject: Re: [PATCH v2] pinctrl: add params in disable_setting for different usage
Date: Mon, 2 Jun 2014 08:39:41 -0700 [thread overview]
Message-ID: <20140602153941.GA11004@atomide.com> (raw)
In-Reply-To: <537F7407.5080404@wwwdotorg.org>
* Stephen Warren <swarren@wwwdotorg.org> [140523 09:16]:
> On 05/22/2014 07:54 PM, FanWu wrote:
> > the pinctrl-single driver is still using ops->disable, if I remove the
> > "disable" in ops, there will be build error in the vendor's code base
> > who is using pinctrl-single driver.
>
> I thought Tony said it was fine to simply remove pinctrl-single's
> ops->disable code completeley.
AFAIK nobody is using it. At least we don't have any references to
pinctrl-single,function-off property in the .dts files.
So removing pcs_disable seems safe to do, the property we probably
want to parse and produce a warning in case somebody is using it
out of tree.
Regards,
Tony
prev parent reply other threads:[~2014-06-02 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 3:10 [PATCH v2] pinctrl: add params in disable_setting for different usage fwu
2014-05-22 3:46 ` FanWu
2014-05-22 23:13 ` Stephen Warren
2014-05-23 1:54 ` FanWu
2014-05-23 16:15 ` Stephen Warren
2014-06-02 15:39 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602153941.GA11004@atomide.com \
--to=tony@atomide.com \
--cc=cxie4@marvell.com \
--cc=fswu@marvell.com \
--cc=fwu@marvell.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=njiang1@marvell.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=tianxf@marvell.com \
--cc=ylmao@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox