Re: [PATCH RFC 1/2] MAINTAINERS: Add "R:" designated-reviewers tag

[josh@joshtriplett.org]

On Mon, Jun 02, 2014 at 12:05:17PM -0700, Joe Perches wrote:
> On Mon, 2014-06-02 at 11:55 -0700, josh@joshtriplett.org wrote:
> > this should go along with a change to
> > get_maintainer.pl to add those folks to the CC list.
> 
> Something like this:

Yes, exactly.  Given an appropriate commit message,
Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> ---
>  scripts/get_maintainer.pl | 22 +++++++++++++++++++++-
>  1 file changed, 21 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 4198788..d701627 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -21,6 +21,7 @@ my $lk_path = "./";
>  my $email = 1;
>  my $email_usename = 1;
>  my $email_maintainer = 1;
> +my $email_reviewer = 1;
>  my $email_list = 1;
>  my $email_subscriber_list = 0;
>  my $email_git_penguin_chiefs = 0;
> @@ -202,6 +203,7 @@ if (!GetOptions(
>  		'remove-duplicates!' => \$email_remove_duplicates,
>  		'mailmap!' => \$email_use_mailmap,
>  		'm!' => \$email_maintainer,
> +		'r!' => \$email_reviewer,
>  		'n!' => \$email_usename,
>  		'l!' => \$email_list,
>  		's!' => \$email_subscriber_list,
> @@ -260,7 +262,8 @@ if ($sections) {
>  }
>  
>  if ($email &&
> -    ($email_maintainer + $email_list + $email_subscriber_list +
> +    ($email_maintainer + $email_reviewer +
> +     $email_list + $email_subscriber_list +
>       $email_git + $email_git_penguin_chiefs + $email_git_blame) == 0) {
>      die "$P: Please select at least 1 email option\n";
>  }
> @@ -750,6 +753,7 @@ MAINTAINER field selection options:
>      --hg-since => hg history to use (default: $email_hg_since)
>      --interactive => display a menu (mostly useful if used with the --git option)
>      --m => include maintainer(s) if any
> +    --r => include reviewer(s) if any
>      --n => include name 'Full Name <addr\@domain.tld>'
>      --l => include list(s) if any
>      --s => include subscriber only list(s) if any
> @@ -1064,6 +1068,22 @@ sub add_categories {
>  		    my $role = get_maintainer_role($i);
>  		    push_email_addresses($pvalue, $role);
>  		}
> +	    } elsif ($ptype eq "R") {
> +		my ($name, $address) = parse_email($pvalue);
> +		if ($name eq "") {
> +		    if ($i > 0) {
> +			my $tv = $typevalue[$i - 1];
> +			if ($tv =~ m/^(\C):\s*(.*)/) {
> +			    if ($1 eq "P") {
> +				$name = $2;
> +				$pvalue = format_email($name, $address, $email_usename);
> +			    }
> +			}
> +		    }
> +		}
> +		if ($email_reviewer) {
> +		    push_email_addresses($pvalue, 'reviewer');
> +		}
>  	    } elsif ($ptype eq "T") {
>  		push(@scm, $pvalue);
>  	    } elsif ($ptype eq "W") {
> 
> 
>