Re: [PATCH 3/5] regulator: axp20x: Update the bindings to use a local parent regulator

Mark Brown
2014-05-28T18:51:08Z

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

On Wed, May 28, 2014 at 07:11:07PM +0200, Maxime Ripard wrote:

> axp_vcore_reg: dcdc2 {
> + vin-supply = <&axp_ipsout_reg>;

> axp_ddr_reg: dcdc3 {
> + vin-supply = <&axp_ipsout_reg>;

> axp_rtc_reg: ldo1 {
> + vin-supply = <&axp_ipsout_reg>;

> axp_analog_reg: ldo2 {
> + vin-supply = <&axp_ipsout_reg>;

> axp_pll_reg: ldo3 {
> + vin-supply = <&axp_ipsout_reg>;

> axp_hdmi_reg: ldo4 {
> + vin-supply = <&axp_ipsout_reg>;

> axp_mic_reg: ldo5 {
> + vin-supply = <&axp_ipsout_reg>;

This is saying that every single regulator on the device is powered by a
(presumably) single input called "vin". This would certainly be an
unusual package design... As ever the name of the supply should follow
the name of the pin on the device.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]