From: Dave Jones <davej@redhat.com>
To: Richard Weinberger <richard@nod.at>
Cc: Peter Zijlstra <peterz@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michael Kerrisk-manpages <mtk.manpages@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: sched: Disallow sched_attr::sched_policy < 0
Date: Tue, 3 Jun 2014 09:16:09 -0400 [thread overview]
Message-ID: <20140603131609.GA26267@redhat.com> (raw)
In-Reply-To: <538D8B96.7080503@nod.at>
On Tue, Jun 03, 2014 at 10:47:18AM +0200, Richard Weinberger wrote:
> Am 03.06.2014 10:32, schrieb Peter Zijlstra:
> > On Tue, Jun 03, 2014 at 10:15:44AM +0200, Richard Weinberger wrote:
> >>> Once upon a time GCC also did warns like that, but my compiler is silent
> >>> :-(
>
> -Wtype-limits is what you're looking for.
>
> /me currently builds some kernel configs to find out how much noise it triggers...
Probably quite a bit I'd bet. There's a load of similar bugs in
coverity's db. Some of them look benign, and are probably there just in
case someone ever changes the type of a var, but it's non-obvious
sometimes if the values a function receives can ever actually be < 0
Dave
next prev parent reply other threads:[~2014-06-03 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140602021319.9A5F9660C19@gitolite.kernel.org>
2014-06-02 20:22 ` sched: Disallow sched_attr::sched_policy < 0 Dave Jones
2014-06-03 8:08 ` Peter Zijlstra
2014-06-03 8:15 ` Richard Weinberger
2014-06-03 8:32 ` Peter Zijlstra
2014-06-03 8:47 ` Richard Weinberger
2014-06-03 13:16 ` Dave Jones [this message]
2014-06-03 16:30 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603131609.GA26267@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=peterz@infradead.org \
--cc=richard@nod.at \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox