From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754378AbaFCT0h (ORCPT ); Tue, 3 Jun 2014 15:26:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28640 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752212AbaFCT0f (ORCPT ); Tue, 3 Jun 2014 15:26:35 -0400 Date: Tue, 3 Jun 2014 21:25:25 +0200 From: Oleg Nesterov To: Steven Rostedt Cc: LKML , Thomas Gleixner , Peter Zijlstra , Andrew Morton , Ingo Molnar , Clark Williams , Linus Torvalds Subject: Re: [BUG] signal: sighand unprotected when accessed by /proc Message-ID: <20140603192525.GA1105@redhat.com> References: <20140603130233.658a6a3c@gandalf.local.home> <20140603172632.GA27956@redhat.com> <20140603140529.048701b9@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140603140529.048701b9@gandalf.local.home> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03, Steven Rostedt wrote: > > You know, this code could use some comments. I may send you a patch, > because that __lock_task_sighand() is doing a lot of subtle things and > there's not a single comment explaining it :-( Yes, agreed. Not only SLAB_DESTROY_BY_RCU is not obvious, local_irq_save() is not clear at all. The latter already has a doc patch from Paul, I'll try to add more comments on top once I see that patch in Linus's tree. But I would be happy if you send the patch ;) And this reminds me... I still think that __lock_task_sighand() should be de-uglified. I already sent the patch, probably I'll resend it. Oleg.