From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: eric.ernst@linux.intel.com
Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
mark.gross@intel.com
Subject: Re: [PATCH v3 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output
Date: Wed, 4 Jun 2014 11:22:40 +0300 [thread overview]
Message-ID: <20140604082240.GM1730@lahna.fi.intel.com> (raw)
In-Reply-To: <1401834316-199359-1-git-send-email-eric.ernst@linux.intel.com>
On Tue, Jun 03, 2014 at 03:25:16PM -0700, eric.ernst@linux.intel.com wrote:
> From: Eric Ernst <eric.ernst@linux.intel.com>
>
> For Baytrail, you should never set a GPIO set to direct_irq
> to output mode. When direct_irq_en is set for a GPIO, it is
> tied directly to an APIC internally, and making the pad output
> does not make any sense. Assert a WARN() in the event this happens.
>
> Signed-off-by: Eric Ernst <eric.ernst@linux.intel.com>
Looks good now thanks,
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2014-06-04 8:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0140602191416.GD1730@lahna.fi.intel.com>
2014-06-02 21:12 ` [PATCH v2 1/1] PINCTRL: Warn if direct IRQ GPIO set to output eric.ernst
2014-06-03 11:06 ` Mika Westerberg
2014-06-03 22:25 ` [PATCH v3 1/1] pinctrl: baytrail: " eric.ernst
2014-06-04 8:22 ` Mika Westerberg [this message]
2014-06-12 7:49 ` Linus Walleij
2014-06-12 18:06 ` [PATCH v4 " eric.ernst
2014-07-07 10:19 ` Linus Walleij
2014-07-07 21:14 ` Linus Walleij
2014-07-09 0:33 ` eric ernst
2014-06-03 12:49 ` [PATCH v2 1/1] PINCTRL: " Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140604082240.GM1730@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=eric.ernst@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.gross@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox