Re: [PATCH 1/2] regulators: Add definition of regulator_set_voltage_time() for !CONFIG_REGULATOR

Mark Brown
2014-06-03T14:54:32Z

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

On Tue, Jun 03, 2014 at 08:10:00PM +0530, Viresh Kumar wrote:
> On 28 May 2014 23:08, Mark Brown <broonie@kernel.org> wrote:
> > Whatever - I don't think the particular code makes any practical
> > difference. We would need to audit existing users who don't have a
> > REGULATOR dependency for breakage though.

> Exactly what kind of drivers are we looking to fix here? These might
> be the possible cases:
> - We are checking 'regulator pointer' before calling and don't need to
> handle anything there..

I'm not sure what you mean by this.

> - None of above are true and drivers aren't checking return value of
> regulator_set_voltage()
> OR
> They are checking it and failing when it failed..

> What do we want to do in these cases?

Well, we would need to look at what the drivers were doing and figure
out something sensible - it really depends why they're trying to set the
regulator and what would happen if it doesn't work. For drivers that
ignore the return value they won't be affected anyway.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]