public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@infradead.org>,
	Shaohua Li <shli@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch]blk-mq: blk_mq_tag_to_rq should handle flush request
Date: Wed, 4 Jun 2014 07:58:03 -0700	[thread overview]
Message-ID: <20140604145803.GA7826@infradead.org> (raw)
In-Reply-To: <538F331F.60101@kernel.dk>

On Wed, Jun 04, 2014 at 08:54:23AM -0600, Jens Axboe wrote:
> >It's not as simple as the added code wants to get a queue from the
> >hwctx, which we can't get at.  I was planning to look into this, but
> >there are various other regressions in the recent block updates that I
> >need to fix before I can even test a tree with this one reverted.
> 
> Which regressions? Performance or crashes?

Both.  I've tracked down the SCSI boot crash and you'll have a patch for
that soon, still working on bisecting the performance crawl, but I'm
getting close.

> >If you can get to sorting this out soon I'd love you to handle it,
> >otherwise I'll look into it as soon as I can.
> 
> Just took a look at it, but I don't see the problematic path. I'm
> looking at wip-9.

scsi_mq_find_tag only gets the scsi host, which may have multiple
queues.  When called from scsi_find_tag we actually have a scsi device,
so that's not an issue, but when called from scsi_host_find_tag the
driver only provides the host.


  reply	other threads:[~2014-06-04 14:58 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09 12:07 [patch]blk-mq: blk_mq_tag_to_rq should handle flush request Shaohua Li
2014-05-09 15:00 ` Christoph Hellwig
2014-05-10  4:00   ` Shaohua Li
2014-05-11 17:40     ` Jens Axboe
2014-05-30 14:09     ` Jens Axboe
2014-06-04 11:11       ` Christoph Hellwig
2014-06-04 14:15         ` Jens Axboe
2014-06-04 14:20           ` Christoph Hellwig
2014-06-04 14:54             ` Jens Axboe
2014-06-04 14:58               ` Christoph Hellwig [this message]
2014-06-04 15:02                 ` Jens Axboe
2014-06-04 15:05                   ` Christoph Hellwig
2014-06-04 15:08                     ` Jens Axboe
2014-06-04 15:10                       ` Christoph Hellwig
2014-06-04 15:11                         ` Jens Axboe
2014-06-04 15:16                           ` Christoph Hellwig
2014-06-04 15:19                             ` Jens Axboe
2014-06-04 15:22                       ` Christoph Hellwig
2014-06-04 15:28                         ` Jens Axboe
2014-06-04 15:31                   ` Christoph Hellwig
2014-06-04 15:39                     ` Jens Axboe
2014-06-04 15:47                       ` Jens Axboe
2014-06-04 16:25                         ` Jens Axboe
2014-06-05  1:27                           ` Shaohua Li
2014-06-05  2:05                             ` Jens Axboe
2014-06-05  2:27                               ` Shaohua Li
2014-06-05  2:40                                 ` Jens Axboe
2014-06-04 15:43                     ` Ming Lei
2014-06-04 15:48                       ` Jens Axboe
2014-06-04 16:00                         ` Ming Lei
2014-06-04 16:09                           ` Jens Axboe
2014-06-04 16:26                             ` Ming Lei
2014-06-04 16:28                               ` Jens Axboe
2014-06-04 16:33                                 ` Christoph Hellwig
2014-06-04 16:36                                   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140604145803.GA7826@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shli@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox