From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Peter Zijlstra <peterz@infradead.org>,
rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, lenb@kernel.org, mingo@kernel.org,
tglx@linutronix.de, hpa@zytor.com, arjan@linux.intel.com,
rui.zhang@intel.com, luto@amacapital.net
Subject: Re: [PATCH] idle, thermal, acpi: Remove home grown idle implementations
Date: Wed, 4 Jun 2014 15:59:20 -0700 [thread overview]
Message-ID: <20140604155920.3fd4e94d@ultegra> (raw)
In-Reply-To: <1509308.hu7EZQqxxC@vostro.rjw.lan>
On Wed, 04 Jun 2014 23:34:51 +0200
"Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
> On Wednesday, June 04, 2014 01:58:12 AM Jacob Pan wrote:
> > On Wed, 4 Jun 2014 10:54:18 +0200
> > Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > >
> > > I'm still sitting on this patch. Jacub you were going to make it
> > > play nice with QoS?
> > >
> > I had a patchset to work through system PM QOS and still maintain
> > the idle injection efficiency. When I saw you did not merge the
> > patch below, I thought you have abandoned it :)
> >
> > The only issue as per our last discussion is the lack of
> > notification when PM QOS cannot be met. But that is intrinsic to PM
> > QOS itself.
> >
> > I also consulted with Arjan and looked at directly intercept with
> > intel_idle since both intel_powerclamp and intel_idle are arch
> > specific drivers. But I think that is hard to do at per idle period
> > basis, since we should still allow "natural" idle during the forced
> > idle time.
> >
> > So, I think we can take a two stepped approach,
> > 1. integrate your patch with a
> > updated version of https://lkml.org/lkml/2013/11/26/534 such that
> > there is no performance/efficiency regression.
> > 2. add notification mechanism to system qos when constraints cannot
> > be met.
>
> And then there's a question about how the notification would be
> supposed to work. So I guess we can proceed with 1. and really leave
> 2. for some time in the future ATM.
Sounds good. Let me test/integrate Peter's patch with PM QoS change,
powerclamp and acpipad then come up with a patchset.
Thanks,
Jacob
next prev parent reply other threads:[~2014-06-04 22:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 8:54 [PATCH] idle, thermal, acpi: Remove home grown idle implementations Peter Zijlstra
2014-06-04 8:58 ` Jacob Pan
2014-06-04 21:34 ` Rafael J. Wysocki
2014-06-04 22:59 ` Jacob Pan [this message]
2014-06-05 7:12 ` Peter Zijlstra
2014-06-05 6:55 ` Peter Zijlstra
2014-06-06 15:47 ` Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140604155920.3fd4e94d@ultegra \
--to=jacob.jun.pan@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox