From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Ingo Molnar <mingo@redhat.com>, Dave Jones <davej@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] perf: Differentiate exec() and non-exec() comm events
Date: Thu, 5 Jun 2014 11:58:36 +0200 [thread overview]
Message-ID: <20140605095836.GB23641@gmail.com> (raw)
In-Reply-To: <20140605095659.GA23641@gmail.com>
* Ingo Molnar <mingo@kernel.org> wrote:
> > Nah, I'll frob it. Thanks!
>
> FYI, this patch breaks pretty much every non-x86 architecture:
>
> /home/mingo/tip/fs/exec.c: In function 'setup_new_exec':
> /home/mingo/tip/fs/exec.c:1113: error: implicit declaration of function 'perf_event_exec'
> make[2]: *** [fs/exec.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [fs] Error 2
> make[1]: *** Waiting for unfinished jobs....
Sorry, it was another patch that broke things:
Author: Peter Zijlstra <peterz@infradead.org>
Date: Wed May 21 17:32:19 2014 +0200
perf: Fix perf_event_comm() vs. exec() assumption
Thanks,
Ingo
prev parent reply other threads:[~2014-06-05 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 8:45 [PATCH] perf: Differentiate exec() and non-exec() comm events Adrian Hunter
2014-05-28 8:55 ` Peter Zijlstra
2014-05-28 9:08 ` Adrian Hunter
2014-05-28 9:53 ` Peter Zijlstra
2014-06-05 9:56 ` Ingo Molnar
2014-06-05 9:58 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605095836.GB23641@gmail.com \
--to=mingo@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=davej@redhat.com \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).