Re: [PATCH 4/9] perf/x86: add cross-HT counter exclusion infrastructure

Maria Dimakopoulou
2014-06-05T13:36:30Z

This is to indicate that the PMU needs to setup the
shared state struct which is called excl_cntrs.
That struct is allocated for all CPUs at first, and
then half of them are destroyed and their CPUs
made to point to their siblings struct.

So yes. EXCL is really related to HT.
It could be called HT_EXCL.

Will fix in V2.

On Thu, Jun 5, 2014 at 11:04 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Wed, Jun 04, 2014 at 11:34:13PM +0200, Stephane Eranian wrote:
>> @@ -499,6 +530,7 @@ do { \
>> */
>> #define PMU_FL_NO_HT_SHARING 0x1 /* no hyper-threading resource sharing */
>> #define PMU_FL_HAS_RSP_1 0x2 /* has 2 equivalent offcore_rsp regs */
>> +#define PMU_FL_EXCL_CNTRS 0x4 /* has exclusive counter requirements */
>
> the EXLC thing is HT specific too, right? How about HT_EXCL or so?
>
>