From: Yuyang Du <yuyang.du@intel.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
rafael.j.wysocki@intel.com,
linux-kernel <linux-kernel@vger.kernel.org>,
Paul Turner <pjt@google.com>,
Benjamin Segall <bsegall@google.com>,
arjan.van.de.ven@intel.com, Len Brown <len.brown@intel.com>,
alan.cox@intel.com, "Gross, Mark" <mark.gross@intel.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
jacob.jun.pan@linux.intel.com,
"fengguang.wu@intel.com" <fengguang.wu@intel.com>
Subject: Re: [PATCH] sched: remove rq's runnable load average
Date: Fri, 6 Jun 2014 06:46:29 +0800 [thread overview]
Message-ID: <20140605224628.GA22261@intel.com> (raw)
In-Reply-To: <CAKfTPtAg6uvhR4hLpifmev4oCPPtuQ1xDWTuxDe2OzG6Ldvk7A@mail.gmail.com>
On Thu, Jun 05, 2014 at 10:32:31AM +0200, Vincent Guittot wrote:
> Hi Yuyang,
>
> I have started to use it in this patchset https://lkml.org/lkml/2014/5/23/458
>
Hi Vincent and PeterZ,
I saw your patchset: https://lkml.org/lkml/2014/5/23/458. But don't take it
wrong, I did not intentionally attempt to remove rq->avg to prevent you from
using it. If your patchset gets merged, sure we should keep it. Otherwise, we
need to see whether there is other objection to remove it, because it has been
almost two years that is not used, I don't see any goodness of it in the
critical path but never used.
In addition, I want to market CPU ConCurrency (CC) as a candidate for CPU
unweighted load metric. Hope you can use it. And also try to answer
PeterZ's question: why not utilization, but CC?
CPU utilization, specifically CPU busy ratio, misses the tasks wanting/using
the CPU. I already explained it several times. So this time I'd like to make
some examples. Take 50% utilization for example, we really can't say 50% is
high or low for scheduler, because if it is just 1 task using it, it is low,
but if 100 tasks sharing it, it is already very high. And take 100%
utilization for example, if it is just 1 task, we can't say it is high in the
sense that give it another CPU does not help. So maybe you want to also
reference nr_running, but nr_running is too dynamic to use as it is.
On the contrary, CC understands not only CPU utilization but also tasks
utilizing the CPU. The averaged metric can 1) tolerate transient tasks as it
evens nr_running, and 2) know when CPU is utilized, because CC should be no
less than CPU utilization in general, 3) we just need to compare it with 1 as
the threshold, so not struggle in selecting what threshold to distinguish high
or low workload in the CPU utilization case. Right?
Thanks,
Yuyang
prev parent reply other threads:[~2014-06-06 6:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 22:51 [PATCH] sched: remove rq's runnable load average Yuyang Du
2014-06-05 8:32 ` Vincent Guittot
2014-06-05 22:46 ` Yuyang Du [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605224628.GA22261@intel.com \
--to=yuyang.du@intel.com \
--cc=alan.cox@intel.com \
--cc=arjan.van.de.ven@intel.com \
--cc=bsegall@google.com \
--cc=fengguang.wu@intel.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.gross@intel.com \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rafael.j.wysocki@intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox