From: Peter Zijlstra <peterz@infradead.org>
To: Pranith Kumar <pranith@gatech.edu>
Cc: linux-kernel@vger.kernel.org, tim.c.chen@linux.intel.com,
davidlohr@hp.com, mingo@redhat.com
Subject: Re: [RFC PATCH 1/1] cleanup: use bool as return type for rwsem_is_locked
Date: Fri, 6 Jun 2014 19:56:55 +0200 [thread overview]
Message-ID: <20140606175655.GX13930@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <5391FFFD.1060901@gatech.edu>
On Fri, Jun 06, 2014 at 01:53:01PM -0400, Pranith Kumar wrote:
> On Fri, Jun 6, 2014 at 3:35 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > Now in general, I don't particularly like such superfluous changes, so
> > unless you can show that GCC actually generates better code, I'd prefer
> > to keep things as they are.
>
> Fixed and checked the assembly. It saves us 2 bytes of code, not much. I am not sure if that is worth it :(
still 2 bytes, so sure.
Which gcc did you use and what arch did you build? That might be useful
info for the changelog.
next prev parent reply other threads:[~2014-06-06 17:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 20:49 [RFC PATCH 1/1] cleanup: use bool as return type for rwsem_is_locked Pranith Kumar
2014-06-06 7:35 ` Peter Zijlstra
2014-06-06 17:53 ` Pranith Kumar
2014-06-06 17:56 ` Peter Zijlstra [this message]
2014-06-06 18:02 ` Pranith Kumar
2014-06-06 18:41 ` Davidlohr Bueso
2014-06-06 18:52 ` Pranith Kumar
2014-06-06 18:11 ` Pranith Kumar
2014-06-07 0:18 ` Dave Chinner
2014-06-07 0:59 ` Pranith Kumar
2014-06-07 1:41 ` Pranith Kumar
2014-06-07 2:39 ` Joe Perches
2014-06-07 23:44 ` Dave Chinner
2014-06-08 2:57 ` Pranith Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606175655.GX13930@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=davidlohr@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pranith@gatech.edu \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox