From: "George Spelvin" <linux@horizon.com>
To: davem@davemloft.net, dborkman@redhat.com, shemminger@osdl.org,
tytso@mit.edu
Cc: linux@horizon.com, linux-kernel@vger.kernel.org
Subject: [PATCH 0/7] random32: Various minor cleanups
Date: 7 Jun 2014 04:18:28 -0400 [thread overview]
Message-ID: <20140607081828.9294.qmail@ns.horizon.com> (raw)
I was looking for self-test code to emulate for lib/glob.c and, while
canvassing other code with self-tests, found some code that made me itch,
so I scratched it.
7 patches;
1/7: Mark the self-test data as __initconst
2/7: Remove excess calls to prandom_u32_state in initialization
3/7: Replace an #ifdef with a stub prandom_state_selftest()
4/7: Use <asm/unaligned.h> instead of hand-rolling it
5/7: Make prandom_u32_max efficient for powers of 2
6/7: Randomize timeout to the millisecond, not the second
7/7: Remove redundant U suffixes on integers
I have a big follow-on patch series to replace all the (many) instances
of "prandom_u32() % x" in the kernel with prandom_u32_max(x), which is
more efficient.
As of patch 5/7, "prandom_u32() & (x-1)" can also be replaced by
"prandom_u32_max(x)", but that's optional.
Patch 6/7 is dubious, and I'd like comments. I just don't see
a reason why integer granularity would be desirable.
next reply other threads:[~2014-06-07 8:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-07 8:18 George Spelvin [this message]
2014-06-07 8:19 ` [PATCH 1/7] lib/random32.c: Mark self-test data as __initconst George Spelvin
2014-06-08 12:06 ` Daniel Borkmann
2014-06-07 8:20 ` [PATCH 2/7] lib/random32.c: Remove excess calls to prandom_u32_state in initialization George Spelvin
2014-06-08 12:11 ` Daniel Borkmann
2014-06-08 12:19 ` George Spelvin
2014-06-07 8:22 ` [PATCH 3/7] lib/random32.c: Replace an #ifdef with a stub prandom_state_selftest() George Spelvin
2014-06-08 12:16 ` Daniel Borkmann
2014-06-08 12:27 ` George Spelvin
2014-06-07 8:25 ` [PATCH 4/7] lib/random32.c: Use <asm/unaligned.h> instead of hand-rolling it George Spelvin
2014-06-08 12:25 ` Daniel Borkmann
2014-06-08 12:40 ` George Spelvin
2014-06-08 20:26 ` Hannes Frederic Sowa
2014-06-10 15:13 ` Daniel Borkmann
2014-06-07 8:28 ` [PATCH 5/7] lib/random32.c: Make prandom_u32_max efficient for powers of 2 George Spelvin
2014-06-08 12:03 ` Daniel Borkmann
2014-06-08 17:34 ` Hannes Frederic Sowa
2014-06-08 20:02 ` Daniel Borkmann
2014-06-09 0:28 ` George Spelvin
2014-06-08 20:48 ` George Spelvin
2014-06-09 10:30 ` Hannes Frederic Sowa
2014-06-07 8:28 ` [PATCH 6/7] lib/random32.c: Randomize timeout to the millisecond, not the second George Spelvin
2014-06-08 10:43 ` Daniel Borkmann
2014-06-08 11:30 ` George Spelvin
2014-06-08 12:28 ` Daniel Borkmann
2014-06-08 12:42 ` George Spelvin
2014-06-08 20:01 ` Daniel Borkmann
2014-06-07 8:31 ` [PATCH 7/7] lib/random32.c: Remove redundant U suffixes on integers George Spelvin
2014-06-08 10:36 ` Daniel Borkmann
2014-06-08 11:14 ` George Spelvin
2014-06-08 12:05 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140607081828.9294.qmail@ns.horizon.com \
--to=linux@horizon.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@osdl.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox