Re: [PATCH 3.12 064/146] Bluetooth: Fix redundant encryption request for reauthentication

Jiri Slaby
2014-06-09T13:52:08Z

On 06/09/2014 03:33 PM, Johan Hedberg wrote:
> Hi,
>
> On Mon, Jun 09, 2014, Jiri Slaby wrote:
>> 3.12-stable review patch. If anyone has any objections, please let me know.
>>
>> ===============
>>
>> commit 09da1f3463eb81d59685df723b1c5950b7570340 upstream.
>>
>> When we're performing reauthentication (in order to elevate the
>> security level from an unauthenticated key to an authenticated one) we
>> do not need to issue any encryption command once authentication
>> completes. Since the trigger for the encryption HCI command is the
>> ENCRYPT_PEND flag this flag should not be set in this scenario.
>> Instead, the REAUTH_PEND flag takes care of all necessary steps for
>> reauthentication.
>>
>> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
>> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>> ---
>> net/bluetooth/hci_conn.c | 9 ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> This one seems to be causing a regression, so it's probably best to keep
> it out of stable trees for now:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=77541

Oh, thanks for letting me know. Now dropped.

thanks,
--
js
suse labs