linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	jolsa@redhat.com, linux-kernel@vger.kernel.org,
	acme@infradead.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/9] perf, tools: Add support for text descriptions of events and alias add
Date: Mon, 9 Jun 2014 18:52:45 +0200	[thread overview]
Message-ID: <20140609165245.GR25366@two.firstfloor.org> (raw)
In-Reply-To: <87ha3ud6ic.fsf@sejong.aot.lge.com>

> Hmm.. this will print the description at right side and I think it'd be
> better if it prints in another line(s) like below:

I think it's better to show the descriptions by default without 
an extra option. I suspect most people want to see them, or if they
need them they won't know about obscure -v options.

> 
>   agu_bypass_cancel.count                            [Kernel PMU event]
>         This event counts executed load operations with all the following
>          traits: 1. addressing of the format [base + offset], 2. the offset
>          is between 1 and 2047, 3. the address specified in the base register
>          is in one page and the address [base+offset] is in an

The problem with this format is that it is not compatible, so it would
break existing parsers that look at perf list output.  That is why I ended up
with the right side format.


>   arith.fpu_div                                      [Kernel PMU event]
>         Divide operations executed
>   arith.fpu_div_active                               [Kernel PMU event]
>         Cycles when divider is busy executing divide operations
>   ...
> 
> 
> I just tweaked it using -v option for perf list.  Below is the change I
> made on top of your series.  What do you think?

I prefer not to apply that patch.

I guess what could make sense is a quiet option to not print
descriptions.

-Andi

  reply	other threads:[~2014-06-09 16:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-30 21:50 perf: Add support for full Intel event lists v5 Andi Kleen
2014-05-30 21:50 ` [PATCH 1/9] perf, tools: Add jsmn `jasmine' JSON parser v2 Andi Kleen
2014-05-30 21:50 ` [PATCH 2/9] perf, tools: Add support for text descriptions of events and alias add Andi Kleen
2014-06-09  4:57   ` Namhyung Kim
2014-06-09 16:52     ` Andi Kleen [this message]
2014-06-10  5:58       ` Namhyung Kim
2014-05-30 21:50 ` [PATCH 3/9] perf, tools: Add support for reading JSON event files v3 Andi Kleen
2014-05-30 21:50 ` [PATCH 4/9] perf, tools: Automatically look for event file name for cpu v2 Andi Kleen
2014-05-30 21:50 ` [PATCH 5/9] perf, tools: Add perf download to download event files v3 Andi Kleen
2014-05-30 21:50 ` [PATCH 6/9] perf, tools: Allow events with dot Andi Kleen
2014-05-30 21:50 ` [PATCH 7/9] perf, tools: Query terminal width and use in perf list Andi Kleen
2014-05-30 21:50 ` [PATCH 8/9] perf, tools, test: Add test case for alias and JSON parsing v2 Andi Kleen
2014-05-30 21:50 ` [PATCH 9/9] perf, tools, record: Always allow to overide default period v2 Andi Kleen
2014-06-04 15:33   ` Namhyung Kim
2014-06-04 16:59     ` Andi Kleen
2014-06-09  5:21       ` Namhyung Kim
2014-06-09  5:56 ` perf: Add support for full Intel event lists v5 Namhyung Kim
2014-06-09 18:01   ` Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2014-06-27 23:15 perf: Add support for full Intel event lists v7 Andi Kleen
2014-06-27 23:15 ` [PATCH 2/9] perf, tools: Add support for text descriptions of events and alias add Andi Kleen
2014-07-09 22:19   ` Jiri Olsa
2014-07-11 22:55     ` Andi Kleen
2014-07-09 22:19   ` Jiri Olsa
2014-06-13 23:02 perf: Add support for full Intel event lists v6 Andi Kleen
2014-06-13 23:02 ` [PATCH 2/9] perf, tools: Add support for text descriptions of events and alias add Andi Kleen
2014-05-15 22:03 perf: Add support for full Intel event lists v4 Andi Kleen
2014-05-15 22:03 ` [PATCH 2/9] perf, tools: Add support for text descriptions of events and alias add Andi Kleen
2014-05-12 22:51 perf: Add support for full Intel event lists v3 Andi Kleen
2014-05-12 22:51 ` [PATCH 2/9] perf, tools: Add support for text descriptions of events and alias add Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140609165245.GR25366@two.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=acme@infradead.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).