From: "Brad Mouring" <bmouring@ni.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Jason Low <jason.low2@hp.com>, Brad Mouring <bmouring@ni.com>
Subject: Re: [patch V3 1/7] rtmutex: Deobfuscate chain walk
Date: Tue, 10 Jun 2014 08:57:21 -0500 [thread overview]
Message-ID: <20140610135721.GA28502@linuxgetsreal> (raw)
In-Reply-To: <20140609202335.980283946@linutronix.de>
On Mon, Jun 09, 2014 at 08:28:06PM -0000, Thomas Gleixner wrote:
> There is no point to keep the task ref across the check for lock
> owner. Drop the ref before that, so the protection context is clear.
>
> Found while documenting the chain walk.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
I also am not a huge fan of the verbiage of the commit message here.
Steven's makes more sense to me, and you basically say the same thing
in the actual commit message.
Reviewed-by: Brad Mouring <brad.mouring@ni.com>
next prev parent reply other threads:[~2014-06-10 13:58 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 20:28 [patch V3 0/7] rtmutex: Code clarification and optimization Thomas Gleixner
2014-06-09 20:28 ` [patch V3 1/7] rtmutex: Deobfuscate chain walk Thomas Gleixner
2014-06-09 20:59 ` Steven Rostedt
2014-06-10 3:52 ` Lai Jiangshan
2014-06-10 3:21 ` Jason Low
2014-06-10 13:57 ` Brad Mouring [this message]
2014-06-09 20:28 ` [patch V3 2/7] rtmutex: Clarify the boost/deboost part Thomas Gleixner
2014-06-10 0:37 ` Steven Rostedt
2014-06-10 3:22 ` Jason Low
2014-06-10 14:04 ` Brad Mouring
2014-06-09 20:28 ` [patch V3 4/7] rtmutex: Siplify remove_waiter() Thomas Gleixner
2014-06-10 0:53 ` Steven Rostedt
2014-06-10 3:35 ` Lai Jiangshan
2014-06-10 3:44 ` Jason Low
2014-06-10 14:10 ` Brad Mouring
2014-06-09 20:28 ` [patch V3 3/7] rtmutex: Document pi chain walk Thomas Gleixner
2014-06-10 0:45 ` Steven Rostedt
2014-06-10 3:51 ` Lai Jiangshan
2014-06-10 14:21 ` Brad Mouring
2014-06-09 20:28 ` [patch V3 5/7] rtmutex: Confine deadlock logic to futex Thomas Gleixner
2014-06-10 0:59 ` Steven Rostedt
2014-06-10 4:03 ` Lai Jiangshan
2014-06-10 17:39 ` Thomas Gleixner
2014-06-09 20:28 ` [patch V3 7/7] rtmutex: Avoid pointless requeueing in the deadlock detection chain walk Thomas Gleixner
2014-06-10 1:20 ` Steven Rostedt
2014-06-10 3:48 ` Jason Low
2014-06-10 17:41 ` Thomas Gleixner
2014-06-10 17:47 ` Steven Rostedt
2014-06-10 20:45 ` Thomas Gleixner
2014-06-10 14:57 ` Brad Mouring
2014-06-10 15:19 ` Steven Rostedt
2014-06-10 17:43 ` Thomas Gleixner
2014-06-10 17:51 ` Steven Rostedt
2014-06-10 20:46 ` Thomas Gleixner
2014-06-09 20:28 ` [patch V3 6/7] rtmutex: Cleanup deadlock detector debug logic Thomas Gleixner
2014-06-10 1:04 ` Steven Rostedt
2014-06-10 15:09 ` Brad Mouring
2014-06-10 0:27 ` [patch V3 0/7] rtmutex: Code clarification and optimization Steven Rostedt
2014-06-10 0:35 ` Steven Rostedt
2014-06-10 3:00 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140610135721.GA28502@linuxgetsreal \
--to=bmouring@ni.com \
--cc=jason.low2@hp.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox