From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Don Zickus <dzickus@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
linux-kernel@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>, Mike Galbraith <efault@gmx.de>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Kyle McMartin <kyle@mcmartin.ca>
Subject: perf tools: MULTILIB install issues. was Re: [PATCH 1/2] perf tools: Emit more precise message for missing glibc static library
Date: Tue, 10 Jun 2014 15:16:36 -0300 [thread overview]
Message-ID: <20140610181636.GA2794@kernel.org> (raw)
In-Reply-To: <20140610155031.GS177152@redhat.com>
Em Tue, Jun 10, 2014 at 11:50:31AM -0400, Don Zickus escreveu:
> I am hijacking your thread for another Makefile problem. It seems like
> you were doing some cleanups here, so I wanted to throw another problem at
> you. :-)
Yeah, I skimmed that discussion about our home grown autoconf
replacement 8-)
> It seems the fedora-kernel guys found a multilib packaging problem and
> posted a patch to clean it up. It is from Kyle McMartin
> (copy-n-pasted).
> +++ b/tools/perf/config/Makefile
> @@ -621,8 +621,12 @@ endif
> ifeq ($(IS_X86_64),1)
> lib = lib64
> else
> +ifdef MULTILIBDIR
> +lib = $(MULTILIBDIR)
> +else
> lib = lib
> endif
> +endif
> libdir = $(prefix)/$(lib)
> # Shell quote (do not use $(call) to accommodate ancient setups);
> Not sure if this is the right way to do this or if you had a better
> solution.
I'm unsure as well, but it looks like something that suits the needs of
distros, right? Anyone?
- Arnaldo
next prev parent reply other threads:[~2014-06-10 18:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 14:11 [GIT PULL 0/2] perf/tests improvements Arnaldo Carvalho de Melo
2014-06-06 14:11 ` [PATCH 1/2] perf tools: Emit more precise message for missing glibc static library Arnaldo Carvalho de Melo
2014-06-10 15:50 ` Don Zickus
2014-06-10 18:16 ` Arnaldo Carvalho de Melo [this message]
2014-06-06 14:11 ` [PATCH 2/2] perf tests: Show the inner make output when an error happens Arnaldo Carvalho de Melo
2014-06-06 14:50 ` Jiri Olsa
2014-06-06 15:45 ` Arnaldo Carvalho de Melo
2014-06-06 14:51 ` [GIT PULL 0/2] perf/tests improvements Jiri Olsa
2014-06-06 15:06 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140610181636.GA2794@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=dzickus@redhat.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox