* [PATCH 1/1] mm/readahead.c: remove unused file_ra_state from count_history_pages
@ 2014-06-10 18:27 Fabian Frederick
2014-06-10 22:56 ` David Rientjes
2014-06-11 0:13 ` Fengguang Wu
0 siblings, 2 replies; 3+ messages in thread
From: Fabian Frederick @ 2014-06-10 18:27 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Andrew Morton, Fengguang Wu
count_history_pages does only call page_cache_prev_hole in rcu_lock
context using address_space mapping. There's no need to have file_ra_state
here.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
mm/readahead.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/readahead.c b/mm/readahead.c
index 0ca36a7..17b9172 100644
--- a/mm/readahead.c
+++ b/mm/readahead.c
@@ -326,7 +326,6 @@ static unsigned long get_next_ra_size(struct file_ra_state *ra,
* - thrashing threshold in memory tight systems
*/
static pgoff_t count_history_pages(struct address_space *mapping,
- struct file_ra_state *ra,
pgoff_t offset, unsigned long max)
{
pgoff_t head;
@@ -349,7 +348,7 @@ static int try_context_readahead(struct address_space *mapping,
{
pgoff_t size;
- size = count_history_pages(mapping, ra, offset, max);
+ size = count_history_pages(mapping, offset, max);
/*
* not enough history pages:
--
1.8.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mm/readahead.c: remove unused file_ra_state from count_history_pages
2014-06-10 18:27 [PATCH 1/1] mm/readahead.c: remove unused file_ra_state from count_history_pages Fabian Frederick
@ 2014-06-10 22:56 ` David Rientjes
2014-06-11 0:13 ` Fengguang Wu
1 sibling, 0 replies; 3+ messages in thread
From: David Rientjes @ 2014-06-10 22:56 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, Andrew Morton, Fengguang Wu
On Tue, 10 Jun 2014, Fabian Frederick wrote:
> count_history_pages does only call page_cache_prev_hole in rcu_lock
> context using address_space mapping. There's no need to have file_ra_state
> here.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Acked-by: David Rientjes <rientjes@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mm/readahead.c: remove unused file_ra_state from count_history_pages
2014-06-10 18:27 [PATCH 1/1] mm/readahead.c: remove unused file_ra_state from count_history_pages Fabian Frederick
2014-06-10 22:56 ` David Rientjes
@ 2014-06-11 0:13 ` Fengguang Wu
1 sibling, 0 replies; 3+ messages in thread
From: Fengguang Wu @ 2014-06-11 0:13 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, Andrew Morton
Acked-by: Fengguang Wu <fengguang.wu@intel.com>
Thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-11 0:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-10 18:27 [PATCH 1/1] mm/readahead.c: remove unused file_ra_state from count_history_pages Fabian Frederick
2014-06-10 22:56 ` David Rientjes
2014-06-11 0:13 ` Fengguang Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox