* [PATCH] Staging: rtl8192e: dot11d: Fixed printk coding style issues
@ 2014-06-11 4:41 A Raghavendra Rao
2014-06-11 4:58 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: A Raghavendra Rao @ 2014-06-11 4:41 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, A Raghavendra Rao
Replaced 'printk' with 'netdev_' function
Signed-off-by: A Raghavendra Rao <arrao@cdac.in>
---
drivers/staging/rtl8192e/dot11d.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/dot11d.c b/drivers/staging/rtl8192e/dot11d.c
index 53da610..ef9da86 100644
--- a/drivers/staging/rtl8192e/dot11d.c
+++ b/drivers/staging/rtl8192e/dot11d.c
@@ -49,6 +49,7 @@ static struct channel_list ChannelPlan[] = {
void dot11d_init(struct rtllib_device *ieee)
{
struct rt_dot11d_info *pDot11dInfo = GET_DOT11D_INFO(ieee);
+
pDot11dInfo->bEnabled = false;
pDot11dInfo->State = DOT11D_STATE_NONE;
@@ -133,12 +134,12 @@ void Dot11d_UpdateCountryIe(struct rtllib_device *dev, u8 *pTaddr,
pTriple = (struct chnl_txpow_triple *)(pCoutryIe + 3);
for (i = 0; i < NumTriples; i++) {
if (MaxChnlNum >= pTriple->FirstChnl) {
- printk(KERN_INFO "Dot11d_UpdateCountryIe(): Invalid country IE, skip it........1\n");
+ netdev_info(dev->dev, "Dot11d_UpdateCountryIe(): Invalid country IE, skip it........1\n");
return;
}
if (MAX_CHANNEL_NUMBER < (pTriple->FirstChnl +
pTriple->NumChnls)) {
- printk(KERN_INFO "Dot11d_UpdateCountryIe(): Invalid country IE, skip it........2\n");
+ netdev_info(dev->dev, "Dot11d_UpdateCountryIe(): Invalid country IE, skip it........2\n");
return;
}
@@ -165,7 +166,7 @@ u8 DOT11D_GetMaxTxPwrInDbm(struct rtllib_device *dev, u8 Channel)
u8 MaxTxPwrInDbm = 255;
if (MAX_CHANNEL_NUMBER < Channel) {
- printk(KERN_INFO "DOT11D_GetMaxTxPwrInDbm(): Invalid Channel\n");
+ netdev_info(dev->dev, "DOT11D_GetMaxTxPwrInDbm(): Invalid Channel\n");
return MaxTxPwrInDbm;
}
if (pDot11dInfo->channel_map[Channel])
@@ -204,7 +205,7 @@ int ToLegalChannel(struct rtllib_device *dev, u8 channel)
}
if (MAX_CHANNEL_NUMBER < channel) {
- printk(KERN_ERR "%s(): Invalid Channel\n", __func__);
+ netdev_err(dev->dev, "%s(): Invalid Channel\n", __func__);
return default_chn;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: rtl8192e: dot11d: Fixed printk coding style issues
2014-06-11 4:41 [PATCH] Staging: rtl8192e: dot11d: Fixed printk coding style issues A Raghavendra Rao
@ 2014-06-11 4:58 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2014-06-11 4:58 UTC (permalink / raw)
To: A Raghavendra Rao; +Cc: devel, A Raghavendra Rao, linux-kernel
On Wed, Jun 11, 2014 at 10:11:55AM +0530, A Raghavendra Rao wrote:
> Replaced 'printk' with 'netdev_' function
>
> Signed-off-by: A Raghavendra Rao <arrao@cdac.in>
> ---
> drivers/staging/rtl8192e/dot11d.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/dot11d.c b/drivers/staging/rtl8192e/dot11d.c
> index 53da610..ef9da86 100644
> --- a/drivers/staging/rtl8192e/dot11d.c
> +++ b/drivers/staging/rtl8192e/dot11d.c
> @@ -49,6 +49,7 @@ static struct channel_list ChannelPlan[] = {
> void dot11d_init(struct rtllib_device *ieee)
> {
> struct rt_dot11d_info *pDot11dInfo = GET_DOT11D_INFO(ieee);
> +
> pDot11dInfo->bEnabled = false;
>
> pDot11dInfo->State = DOT11D_STATE_NONE;
This change doesn't match what you said you did :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Staging: rtl8192e: dot11d: Fixed printk coding style issues
@ 2014-06-11 4:58 A Raghavendra Rao
0 siblings, 0 replies; 3+ messages in thread
From: A Raghavendra Rao @ 2014-06-11 4:58 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, A Raghavendra Rao
Replaced 'printk' with 'netdev_' function
Signed-off-by: A Raghavendra Rao <arrao@cdac.in>
---
drivers/staging/rtl8192e/dot11d.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/dot11d.c b/drivers/staging/rtl8192e/dot11d.c
index 53da610..bfcc935 100644
--- a/drivers/staging/rtl8192e/dot11d.c
+++ b/drivers/staging/rtl8192e/dot11d.c
@@ -133,12 +133,12 @@ void Dot11d_UpdateCountryIe(struct rtllib_device *dev, u8 *pTaddr,
pTriple = (struct chnl_txpow_triple *)(pCoutryIe + 3);
for (i = 0; i < NumTriples; i++) {
if (MaxChnlNum >= pTriple->FirstChnl) {
- printk(KERN_INFO "Dot11d_UpdateCountryIe(): Invalid country IE, skip it........1\n");
+ netdev_info(dev->dev, "Dot11d_UpdateCountryIe(): Invalid country IE, skip it........1\n");
return;
}
if (MAX_CHANNEL_NUMBER < (pTriple->FirstChnl +
pTriple->NumChnls)) {
- printk(KERN_INFO "Dot11d_UpdateCountryIe(): Invalid country IE, skip it........2\n");
+ netdev_info(dev->dev, "Dot11d_UpdateCountryIe(): Invalid country IE, skip it........2\n");
return;
}
@@ -165,7 +165,7 @@ u8 DOT11D_GetMaxTxPwrInDbm(struct rtllib_device *dev, u8 Channel)
u8 MaxTxPwrInDbm = 255;
if (MAX_CHANNEL_NUMBER < Channel) {
- printk(KERN_INFO "DOT11D_GetMaxTxPwrInDbm(): Invalid Channel\n");
+ netdev_info(dev->dev, "DOT11D_GetMaxTxPwrInDbm(): Invalid Channel\n");
return MaxTxPwrInDbm;
}
if (pDot11dInfo->channel_map[Channel])
@@ -204,7 +204,7 @@ int ToLegalChannel(struct rtllib_device *dev, u8 channel)
}
if (MAX_CHANNEL_NUMBER < channel) {
- printk(KERN_ERR "%s(): Invalid Channel\n", __func__);
+ netdev_err(dev->dev, "%s(): Invalid Channel\n", __func__);
return default_chn;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-11 5:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-11 4:41 [PATCH] Staging: rtl8192e: dot11d: Fixed printk coding style issues A Raghavendra Rao
2014-06-11 4:58 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-06-11 4:58 A Raghavendra Rao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox