From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@shadowen.org>,
LKML <linux-kernel@vger.kernel.org>,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [RFC PATCH] checkpatch: Attempt to find unnecessary 'out of memory' messages
Date: Wed, 11 Jun 2014 10:47:04 +0300 [thread overview]
Message-ID: <20140611074704.GS5015@mwanda> (raw)
In-Reply-To: <1402419340.30479.18.camel@joe-AO725>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
This check introduces 1849 new checkpatch.pl warnings. I looked through
the first 70 warnings and there were no false positives.
Besides the bloat issue, I don't like these warnings because they make
the error handling harder to read. They are sort of a mindless thing
that people feel they have to do for no particular reason. Since
people aren't thinking when they write the error message then you get
NULL dereferences and so on.
regards,
dan carpenter
next prev parent reply other threads:[~2014-06-11 7:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 16:55 [RFC PATCH] checkpatch: Attempt to find unnecessary 'out of memory' messages Joe Perches
2014-06-11 7:47 ` Dan Carpenter [this message]
2014-06-11 16:01 ` Joe Perches
2014-06-14 7:40 ` Julia Lawall
2014-06-14 8:30 ` Joe Perches
2014-06-14 9:51 ` Julia Lawall
2014-06-18 19:33 ` Paul E. McKenney
2014-06-18 19:49 ` Joe Perches
2014-06-19 21:00 ` Paul E. McKenney
2014-06-19 23:24 ` [RFC PATCH] use snprintf instead of sprintf in rcu_torture_printk Pranith Kumar
2014-06-19 23:33 ` Joe Perches
2014-06-20 0:11 ` Pranith Kumar
2014-06-19 23:49 ` Paul E. McKenney
2014-06-20 0:13 ` Pranith Kumar
2014-06-20 4:54 ` Paul E. McKenney
2014-06-20 22:04 ` Joe Perches
2014-06-18 21:18 ` [RFC PATCH] checkpatch: Attempt to find unnecessary 'out of memory' messages Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611074704.GS5015@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox