Re: [PATCH 0/2] x86,vdso,kbuild: Fix vdso_install

Andy Lutomirski
2014-06-11T19:01:53Z

On Wed, Jun 11, 2014 at 11:44 AM, Sam Ravnborg <sam@ravnborg.org> wrote:
> On Wed, Jun 11, 2014 at 12:41:56PM -0400, Josh Boyer wrote:
>> On Wed, Jun 11, 2014 at 12:36 PM, Sam Ravnborg <sam@ravnborg.org> wrote:
>> > On Wed, Jun 11, 2014 at 09:20:05AM -0700, Andy Lutomirski wrote:
>> >> This changes kbuild slightly because I didn't want to fight with using
>> >> static pattern rules and extra obfuscated fake targets just to write a
>> >> loop.
>> >
>> > What are you trying to fix with this?
>> >
>> > On my box (32 bit Intel) "make MODLIB=~/mod vdso_install"
>> > works as expected.
>> > Two *.so files are installed as a copy of the so.dbg files.
>>
>> With what tree?
> Linus latest - yes.
>
>> With Linus' latest, I reported an error because
>> commit 6f121e548f83674ab4920a4e60afb58d4f61b829 breaks the
>> vdso_install target.
> This is your bug-report: http://marc.info/?l=linux-kernel&m=140249607823283&w=2
>
> + make -s ARCH=x86_64
> INSTALL_MOD_PATH=/home/jwboyer/rpmbuild/BUILDROOT/kernel-3.16.0-0.rc0.git1.1.fc21.x86_64
> vdso_install KERNELRELEASE=3.16.0-0.rc0.git1.1.fc21.x86_64
> make[1]: *** No rule to make target `arch/x86/vdso/vdso.so.dbg',
> needed by `vdso.so'. Stop.
> make: *** [vdso_install] Error 2
>
> I am building for i386 which is why I do not see the bug.

I didn't actually check whether all of the code I removed in the patch
was wrong or just some.

If you have a better suggestion for how to structure the makefile
rule, I'd be interested. I don't speak makefilese very well.

--Andy