Re: [PATCH v7] NVMe: conversion to blk-mq

Keith Busch
2014-06-13T19:22:57Z

On Fri, 13 Jun 2014, Jens Axboe wrote:
> OK, same setup as mine. The affinity hint is really screwing us over, no
> question about it. We just need a:
>
> irq_set_affinity_hint(dev->entry[nvmeq->cq_vector].vector, hctx->cpumask);
>
> in the ->init_hctx() methods to fix that up.
>
> That brings us to roughly the same performance, except for the cases
> where the dd is run on the thread sibling of the core handling the
> interrupt. And granted, with the 16 queues used, that'll happen on
> blk-mq. But since you have 32 threads and just 31 IO queues, the non
> blk-mq driver must end up sharing for some cases, too.
>
> So what do we care most about here? Consistency, or using all queues at
> all costs?

I think we want to use all h/w queues regardless of mismatched sharing. A
24 thread server shouldn't use more of the hardware than a 32.

You're right, the current driver shares the queues on anything with 32
or more cpus with this NVMe controller, but we wrote an algorithm that
allocates the most and tries to group them with their nearest neighbors.

One performance oddity we observe is that servicing the interrupt on the
thread sibling of the core that submitted the I/O is the worst performing
cpu you can chose; it's actually better to use a different core on the
same node. At least that's true as long as you're not utilizing the cpus
for other work, so YMMV.