* [PATCH 1/1] drivers/misc/sgi-gru/grukdump.c: remove unnecessary test on unsigned int
@ 2014-06-11 18:47 Fabian Frederick
2014-06-11 19:44 ` Dimitri Sivanich
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-06-11 18:47 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Dimitri Sivanich
unsigned value is never < 0
Cc: Dimitri Sivanich <sivanich@sgi.com>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/misc/sgi-gru/grukdump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c
index a3700a5..e0e0e7e 100644
--- a/drivers/misc/sgi-gru/grukdump.c
+++ b/drivers/misc/sgi-gru/grukdump.c
@@ -196,7 +196,7 @@ int gru_dump_chiplet_request(unsigned long arg)
return -EFAULT;
/* Currently, only dump by gid is implemented */
- if (req.gid >= gru_max_gids || req.gid < 0)
+ if (req.gid >= gru_max_gids)
return -EINVAL;
gru = GID_TO_GRU(req.gid);
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] drivers/misc/sgi-gru/grukdump.c: remove unnecessary test on unsigned int
2014-06-11 18:47 [PATCH 1/1] drivers/misc/sgi-gru/grukdump.c: remove unnecessary test on unsigned int Fabian Frederick
@ 2014-06-11 19:44 ` Dimitri Sivanich
0 siblings, 0 replies; 2+ messages in thread
From: Dimitri Sivanich @ 2014-06-11 19:44 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel
Acked-by: Dimitri Sivanich <sivanich@sgi.com>
On Wed, Jun 11, 2014 at 08:47:02PM +0200, Fabian Frederick wrote:
> unsigned value is never < 0
>
> Cc: Dimitri Sivanich <sivanich@sgi.com>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/misc/sgi-gru/grukdump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c
> index a3700a5..e0e0e7e 100644
> --- a/drivers/misc/sgi-gru/grukdump.c
> +++ b/drivers/misc/sgi-gru/grukdump.c
> @@ -196,7 +196,7 @@ int gru_dump_chiplet_request(unsigned long arg)
> return -EFAULT;
>
> /* Currently, only dump by gid is implemented */
> - if (req.gid >= gru_max_gids || req.gid < 0)
> + if (req.gid >= gru_max_gids)
> return -EINVAL;
>
> gru = GID_TO_GRU(req.gid);
> --
> 1.8.4.5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-11 19:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-11 18:47 [PATCH 1/1] drivers/misc/sgi-gru/grukdump.c: remove unnecessary test on unsigned int Fabian Frederick
2014-06-11 19:44 ` Dimitri Sivanich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox