From: josh@joshtriplett.org
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 5/5] kernel/rcu/rcutorture.c:185 fix a sparse warning
Date: Wed, 11 Jun 2014 14:47:52 -0700 [thread overview]
Message-ID: <20140611214752.GC16940@cloud> (raw)
In-Reply-To: <1402519183-12752-6-git-send-email-bobby.prani@gmail.com>
On Wed, Jun 11, 2014 at 04:39:43PM -0400, Pranith Kumar wrote:
> fix the following sparse warning
>
> kernel/rcu/rcutorture.c:185:1: warning: symbol 'boost_mutex' was not declared. Should it be static?
>
> by marking boost_mutex as a static mutex
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Please preserve the comment alignment (by deleting a tab). With that
fixed:
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> kernel/rcu/rcutorture.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index 7fa34f8..1cd4b2d 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -182,7 +182,7 @@ static u64 notrace rcu_trace_clock_local(void)
> #endif /* #else #ifdef CONFIG_RCU_TRACE */
>
> static unsigned long boost_starttime; /* jiffies of next boost test start. */
> -DEFINE_MUTEX(boost_mutex); /* protect setting boost_starttime */
> +static DEFINE_MUTEX(boost_mutex); /* protect setting boost_starttime */
> /* and boost task create/destroy. */
> static atomic_t barrier_cbs_count; /* Barrier callbacks registered. */
> static bool barrier_phase; /* Test phase. */
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-06-11 21:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 20:39 [RFC PATCH 0/5] rcu: fix sparse warnings Pranith Kumar
2014-06-11 20:39 ` [RFC PATCH 1/5] kernel/rcu/tree.c:1272 fix a sparse warning Pranith Kumar
2014-06-12 23:16 ` Paul E. McKenney
2014-06-13 4:54 ` Pranith Kumar
2014-06-13 5:52 ` Pranith Kumar
2014-06-11 20:39 ` [RFC PATCH 2/5] kernel/rcu/tree_plugin.h:1494 " Pranith Kumar
2014-06-26 19:39 ` Paul E. McKenney
2014-06-11 20:39 ` [RFC PATCH 3/5] kernel/rcu/tree_plugin.h:990 " Pranith Kumar
2014-06-26 19:39 ` Paul E. McKenney
2014-06-11 20:39 ` [RFC PATCH 4/5] kernel/rcu/tree.c:3435 " Pranith Kumar
2014-06-11 21:25 ` josh
2014-06-12 1:37 ` Pranith Kumar
2014-06-11 20:39 ` [RFC PATCH 5/5] kernel/rcu/rcutorture.c:185 " Pranith Kumar
2014-06-11 21:47 ` josh [this message]
2014-07-08 22:35 ` Paul E. McKenney
2014-07-08 22:46 ` Pranith Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611214752.GC16940@cloud \
--to=josh@joshtriplett.org \
--cc=bobby.prani@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).