From: "Chen, Gong" <gong.chen@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: tony.luck@intel.com, m.chehab@samsung.com, rostedt@goodmis.org,
linux-acpi@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/7 v7] trace, RAS: Add eMCA trace event interface
Date: Wed, 11 Jun 2014 22:42:52 -0400 [thread overview]
Message-ID: <20140612024252.GA18991@gchen.bj.intel.com> (raw)
In-Reply-To: <20140611190214.GE14923@pd.tnic>
[-- Attachment #1: Type: text/plain, Size: 898 bytes --]
On Wed, Jun 11, 2014 at 09:02:15PM +0200, Borislav Petkov wrote:
> > +EXPORT_SYMBOL_GPL(cper_mem_err_pack);
>
> Why do we export this one and the one below? What .config warrants this?
>
> CONFIG_ACPI_EXTLOG=m doesn't need them, AFAICT.
>
Right. acpi_extlog doesn't use it. They can be exported later until needed.
> > + TP_STRUCT__entry(
> > + __field(u32, err_seq)
> > + __field(u8, etype)
> > + __field(u8, sev)
> > + __field(u64, pa)
> > + __field(u8, pa_mask_lsb)
> > + __array(u8, fru_id, 40)
>
> How did you come up with this magic number? Why isn't that sizeof(uuid_le)?
Cause I want to convert it into a string.
> > + snprintf(__entry->fru_id, 39, "%pUl", fru_id);
>
> Yeah, I didn't catch the reasoning behind why we need to convert the FRU
> into a string and not leave it simply as u8[16]...
Fair enough. It can be compressed a little bit more.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-06-12 3:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1402475691-30045-1-git-send-email-gong.chen@linux.intel.com>
[not found] ` <1402475691-30045-2-git-send-email-gong.chen@linux.intel.com>
2014-06-11 18:59 ` [PATCH 1/7 v5] trace, RAS: Add basic RAS trace event Borislav Petkov
[not found] ` <1402475691-30045-3-git-send-email-gong.chen@linux.intel.com>
2014-06-11 19:00 ` [PATCH 2/7 v3] trace, AER: Move trace into unified interface Borislav Petkov
[not found] ` <1402475691-30045-5-git-send-email-gong.chen@linux.intel.com>
2014-06-11 19:01 ` [PATCH 4/7 v2] RAS, debugfs: Add debugfs interface for RAS subsystem Borislav Petkov
[not found] ` <1402475691-30045-6-git-send-email-gong.chen@linux.intel.com>
2014-06-11 19:02 ` [PATCH 5/7 v7] trace, RAS: Add eMCA trace event interface Borislav Petkov
2014-06-12 2:42 ` Chen, Gong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140612024252.GA18991@gchen.bj.intel.com \
--to=gong.chen@linux.intel.com \
--cc=bp@alien8.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox