Re: [PATCH -mm v2 8/8] slab: make dead memcg caches discard free slabs immediately

Vladimir Davydov
2014-06-09T13:04:29Z

On Fri, Jun 06, 2014 at 09:52:17AM -0500, Christoph Lameter wrote:
> On Fri, 6 Jun 2014, Vladimir Davydov wrote:
>
> > @@ -740,7 +740,8 @@ static void start_cpu_timer(int cpu)
> > }
> > }
> >
> > -static struct array_cache *alloc_arraycache(int node, int entries,
> > +static struct array_cache *alloc_arraycache(struct kmem_cache *cachep,
> > + int node, int entries,
> > int batchcount, gfp_t gfp)
> > {
> > int memsize = sizeof(void *) * entries + sizeof(struct array_cache);
>
> If you pass struct kmem_cache * into alloc_arraycache then we do not need
> to pass entries or batchcount because they are available in struct
> kmem_cache.

Seems you're right. Will rework.

> Otherwise this patch looks a bit too large to me. Simplify a bit?

Yeah, exactly. I will split it and resend.

Thank you.