Re: [PATCH] staging: slicoss: Fix coding style issue

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Jun 13, 2014 at 05:52:33PM +0200, Benedict Boerger wrote:
> Fix a coding style issue found by checkpatch.pl.
> Use ether_addr_copy instead of memcpy.
> 
> Done to complete a eudyptula task.
> 
> Signed-off-by: Benedict Boerger <benedict.boerger@cs.tu-dortmund.de>
> 
> ---
>  drivers/staging/slicoss/slicoss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index 48841e7..02807a3 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -1790,7 +1790,7 @@ static int slic_mcast_add_list(struct adapter *adapter, char *address)
>  	if (mcaddr == NULL)
>  		return 1;
>  
> -	memcpy(mcaddr->address, address, ETH_ALEN);
> +	ether_addr_copy(mcaddr->address, address);
>  
>  	mcaddr->next = adapter->mcastaddrs;
>  	adapter->mcastaddrs = mcaddr;

Are you sure this is correct?  It's not always a one-to-one replacement
from what I have been told.

thanks,

greg k-h