From: Bob Copeland <me@bobcopeland.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH V2] fs/omfs/inode.c: use ULLONG_MAX instead of ~0ULL
Date: Sun, 15 Jun 2014 12:11:42 -0400 [thread overview]
Message-ID: <20140615161142.GC15404@localhost> (raw)
In-Reply-To: <1402814360-3122-1-git-send-email-fabf@skynet.be>
On Sun, Jun 15, 2014 at 08:39:20AM +0200, Fabian Frederick wrote:
> Use more explicit kernel.h definition
> array_size = DIV_ROUND_UP(bitmap_size, sb->s_blocksize);
>
> - if (sbi->s_bitmap_ino == ~0ULL)
> + if (sbi->s_bitmap_ino == ULLONG_MAX)
> goto out;
So I agree they are the same, but is there a good reason for the
change?
Semantically, I think of ~0ULL as "all ones" whereas ULLONG_MAX
as a maximum of a magnitude comparison, which this is not really.
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2014-06-15 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-15 6:39 [PATCH V2] fs/omfs/inode.c: use ULLONG_MAX instead of ~0ULL Fabian Frederick
2014-06-15 16:11 ` Bob Copeland [this message]
2014-06-16 18:59 ` Fabian Frederick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140615161142.GC15404@localhost \
--to=me@bobcopeland.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox