From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Nick Krause <xerofoify@gmail.com>
Cc: "Maxime Ripard" <maxime.ripard@free-electrons.com>,
"Emilio López" <emilio@elopez.com.ar>,
"Mike Turquette" <mturquette@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Frees gate after if statement in clk-sunxi.c
Date: Mon, 16 Jun 2014 09:15:39 +0100 [thread overview]
Message-ID: <20140616081538.GV23430@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAPDOMVimRry7XejNt9gdqLX4C64T7qsOwEBGvpYLDvxa2H5xuA@mail.gmail.com>
On Sun, Jun 15, 2014 at 11:31:41PM -0400, Nick Krause wrote:
> Seems the bug is fixed , don't worry about resent patch.
> Thanks Nick
>
> On Sun, Jun 15, 2014 at 11:21 PM, Nick Krause <xerofoify@gmail.com> wrote:
> > @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct
> > device_node *node)
> > u32 rate;
> >
> > if (of_property_read_u32(node, "clock-frequency", &rate))
> > + kfree(gate);
> > return;
In any case, the kernel is not coded in Python.
C uses braces { } to enclose blocks of code, and does not care about
indentation - indentation is meaningless to C. Python purely identifies
blocks of code by indentation alone.
Please take account of the programming language when creating patches.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
prev parent reply other threads:[~2014-06-16 8:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-14 18:11 [PATCH] Frees gate after if statement in clk-sunxi.c Nick
2014-06-14 19:35 ` Sergei Shtylyov
2014-06-14 22:06 ` Adam Baker
2014-06-15 20:30 ` Maxime Ripard
2014-06-16 3:21 ` Nick Krause
2014-06-16 3:31 ` Nick Krause
2014-06-16 8:15 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140616081538.GV23430@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=emilio@elopez.com.ar \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@linaro.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox