Re: [PATCH 09/13] purgatory: Core purgatory functionality

Vivek Goyal
2014-06-16T17:26:27Z

On Fri, Jun 13, 2014 at 12:17:13PM +0200, Borislav Petkov wrote:
> On Fri, Jun 06, 2014 at 03:51:04PM -0400, Vivek Goyal wrote:
> > On Thu, Jun 05, 2014 at 10:05:23PM +0200, Borislav Petkov wrote:
> >
> > [..]
> > > > @@ -249,6 +254,7 @@ archclean:
> > > > $(Q)rm -rf $(objtree)/arch/x86_64
> > > > $(Q)$(MAKE) $(clean)=$(boot)
> > > > $(Q)$(MAKE) $(clean)=arch/x86/tools
> > >
> > > ifeq ($(CONFIG_KEXEC),y)
> > > $(Q)$(MAKE) $(clean)=arch/x86/purgatory
> > > endif
> >
> > Hmm.., is it strictly required? I am wondering what happens if I build
> > a kernel with CONFIG_KEXEC=y, then set CONFIG_KEXEC=n and do "make clean".
>
> Try it - it works here.
>
> > I think I will still like any files in arch/x86/purgatory to be cleaned
> > despite the fact that CONFIG_KEXEC=n. Isn't it?
>
> Yep, that works. Conversely, we don't want people who haven't enabled
> KEXEC ever to have unrelated cleanup delay.
>

I tried following with CONFIG_KEXEC=n

ifeq ($(CONFIG_KEXEC),y)
$(Q)$(MAKE) $(clean)=arch/x86/purgatory
endif

And still "make V=1 clean" shows me that it is going in purgatory dir
to clean things up.

make -f scripts/Makefile.clean obj=arch/x86/purgatory

Thanks
Vivek