Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

Michael Kerrisk
2014-06-04T19:39:33Z

Vivek,

As per Documentation/SubmitChecklist , please CC linux-api@ on patces
that change the ABI/API. See
https://www.kernel.org/doc/man-pages/linux-api-ml.html.

Also, is there some draft man page for this new system call?

Thanks,

Michael

On Wed, Jun 4, 2014 at 7:50 PM, Vivek Goyal <vgoyal@redhat.com> wrote:
> On Wed, Jun 04, 2014 at 05:22:14PM +0800, WANG Chao wrote:
>
> [..]
>> > Index: kexec-tools/kexec/kexec.h
>> > ===================================================================
>> > --- kexec-tools.orig/kexec/kexec.h 2014-06-02 14:34:16.719774316 -0400
>> > +++ kexec-tools/kexec/kexec.h 2014-06-02 14:34:42.010036325 -0400
>> > @@ -156,6 +156,13 @@ struct kexec_info {
>> > unsigned long kexec_flags;
>> > unsigned long backup_src_start;
>> > unsigned long backup_src_size;
>> > + /* Set to 1 if we are using kexec2 syscall */
>> > + unsigned long file_mode :1;
>> > +
>> > + /* Filled by kernel image processing code */
>> > + int initrd_fd;
>> > + char *command_line;
>> > + int command_line_len;
>> > };
>> >
>> > struct arch_map_entry {
>> > @@ -207,6 +214,7 @@ extern int file_types;
>> > #define OPT_UNLOAD 'u'
>> > #define OPT_TYPE 't'
>> > #define OPT_PANIC 'p'
>> > +#define OPT_USE_KEXEC2_SYSCALL 's'
>> > #define OPT_MEM_MIN 256
>> > #define OPT_MEM_MAX 257
>> > #define OPT_REUSE_INITRD 258
>> > @@ -230,6 +238,7 @@ extern int file_types;
>> > { "mem-min", 1, 0, OPT_MEM_MIN }, \
>> > { "mem-max", 1, 0, OPT_MEM_MAX }, \
>> > { "reuseinitrd", 0, 0, OPT_REUSE_INITRD }, \
>> > + { "use-kexec2-syscall", 0, 0, OPT_USE_KEXEC2_SYSCALL }, \
>> > { "debug", 0, 0, OPT_DEBUG }, \
>> >
>> > #define KEXEC_OPT_STR "h?vdfxluet:p"
>>
>> This line,
>> #define KEXEC_OPT_STR "h?vdfxluet:p"
>>
>> should be something like,
>> #define KEXEC_OPT_STR "h?vdfxluet:ps"
>
> Thanks chao. I will fix it.
>
> Thanks
> Vivek
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
Michael Kerrisk Linux man-pages maintainer;
http://www.kernel.org/doc/man-pages/
Author of "The Linux Programming Interface", http://blog.man7.org/