From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: sameo@linux.intel.com, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] mfd: arizona: Use num_core_supplies in arizona_dev_exit
Date: Tue, 17 Jun 2014 15:36:31 +0100 [thread overview]
Message-ID: <20140617143631.GE29841@lee--X1> (raw)
In-Reply-To: <1401699043-16835-5-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Mon, 02 Jun 2014, Charles Keepax wrote:
> Currently we call regulator_bulk_disable with
> ARRAY_SIZE(arizona->core_supplies), however this array may be larger
> than the number of supplies actually used by the chip we are dealing
> with. Use the provided num_core_supplies member instead, so that we only
> disable supplies which actually exist.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/arizona-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 7678e84..51c0110 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -1039,7 +1039,7 @@ int arizona_dev_exit(struct arizona *arizona)
> if (arizona->pdata.reset)
> gpio_set_value_cansleep(arizona->pdata.reset, 0);
>
> - regulator_bulk_disable(ARRAY_SIZE(arizona->core_supplies),
> + regulator_bulk_disable(arizona->num_core_supplies,
> arizona->core_supplies);
> return 0;
> }
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-06-17 14:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 8:50 [PATCH 0/5] Arizona clean up driver removal and error paths Charles Keepax
2014-06-02 8:50 ` [PATCH 1/5] mfd: arizona: Disable PM runtime at start of driver removal Charles Keepax
2014-06-17 14:33 ` Lee Jones
2014-06-02 8:50 ` [PATCH 2/5] mfd: arizona: Disable DCVDD before we destroy the MFD Charles Keepax
2014-06-17 14:33 ` Lee Jones
2014-06-02 8:50 ` [PATCH 3/5] mfd: arizona: Don't use devres for DCVDD Charles Keepax
2014-06-17 14:36 ` Lee Jones
2014-06-17 15:17 ` Charles Keepax
2014-06-02 8:50 ` [PATCH 4/5] mfd: arizona: Use num_core_supplies in arizona_dev_exit Charles Keepax
2014-06-17 14:36 ` Lee Jones [this message]
2014-06-02 8:50 ` [PATCH 5/5] mfd: arizona: Lower ARIZONA_MAX_CORE_SUPPLIES to 2 Charles Keepax
2014-06-17 14:36 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617143631.GE29841@lee--X1 \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox