Re: [PATCH 2/5] mfd: arizona: Disable DCVDD before we destroy the MFD

Lee Jones
2014-06-17T14:34:02Z

On Mon, 02 Jun 2014, Charles Keepax wrote:

> As DCVDD is probably supplied by a child of the MFD device move its
> disable to before we destroy the MFD children as the regulator likely
> won't exist after that.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/arizona-core.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 7bdc0f5..48acac6 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -1026,6 +1026,8 @@ int arizona_dev_exit(struct arizona *arizona)
> {
> pm_runtime_disable(arizona->dev);
>
> + regulator_disable(arizona->dcvdd);
> +
> mfd_remove_devices(arizona->dev);
> arizona_free_irq(arizona, ARIZONA_IRQ_UNDERCLOCKED, arizona);
> arizona_free_irq(arizona, ARIZONA_IRQ_OVERCLOCKED, arizona);
> @@ -1033,7 +1035,7 @@ int arizona_dev_exit(struct arizona *arizona)
> arizona_irq_exit(arizona);
> if (arizona->pdata.reset)
> gpio_set_value_cansleep(arizona->pdata.reset, 0);
> - regulator_disable(arizona->dcvdd);
> +
> regulator_bulk_disable(ARRAY_SIZE(arizona->core_supplies),
> arizona->core_supplies);
> return 0;

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog