* [PATCH 09/24] drivers/iommu: check actual error on iommu_init
@ 2014-06-17 14:29 Jeff Liu
2014-06-17 15:21 ` Joerg Roedel
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Liu @ 2014-06-17 14:29 UTC (permalink / raw)
To: joro; +Cc: iommu, LKML
From: Jie Liu <jeff.liu@oracle.com>
kset_create_and_add() has been fixed to return the actual error
code ptr rather than NULL, so update iommu_init() to check the
return value via IS_ERR() accordingly.
Cc: Joerg Roedel <joro@8bytes.org>
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
drivers/iommu/iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index e5555fc..297b5ad 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -925,7 +925,7 @@ static int __init iommu_init(void)
ida_init(&iommu_group_ida);
mutex_init(&iommu_group_mutex);
- BUG_ON(!iommu_group_kset);
+ BUG_ON(IS_ERR(iommu_group_kset));
return 0;
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 09/24] drivers/iommu: check actual error on iommu_init
2014-06-17 14:29 [PATCH 09/24] drivers/iommu: check actual error on iommu_init Jeff Liu
@ 2014-06-17 15:21 ` Joerg Roedel
2014-06-17 19:24 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Joerg Roedel @ 2014-06-17 15:21 UTC (permalink / raw)
To: Jeff Liu; +Cc: iommu, LKML
On Tue, Jun 17, 2014 at 10:29:19PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> kset_create_and_add() has been fixed to return the actual error
> code ptr rather than NULL, so update iommu_init() to check the
> return value via IS_ERR() accordingly.
>
> Cc: Joerg Roedel <joro@8bytes.org>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Acked-by: Joerg Roedel <joro@8bytes.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 09/24] drivers/iommu: check actual error on iommu_init
2014-06-17 15:21 ` Joerg Roedel
@ 2014-06-17 19:24 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2014-06-17 19:24 UTC (permalink / raw)
To: Joerg Roedel; +Cc: Jeff Liu, iommu, LKML
On Tue, Jun 17, 2014 at 05:21:54PM +0200, Joerg Roedel wrote:
> On Tue, Jun 17, 2014 at 10:29:19PM +0800, Jeff Liu wrote:
> > From: Jie Liu <jeff.liu@oracle.com>
> >
> > kset_create_and_add() has been fixed to return the actual error
> > code ptr rather than NULL, so update iommu_init() to check the
> > return value via IS_ERR() accordingly.
> >
> > Cc: Joerg Roedel <joro@8bytes.org>
> > Signed-off-by: Jie Liu <jeff.liu@oracle.com>
>
> Acked-by: Joerg Roedel <joro@8bytes.org>
Nope, please do not take this patch, it is not needed and as the kset
call is not changing, it will be incorrect.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-17 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-17 14:29 [PATCH 09/24] drivers/iommu: check actual error on iommu_init Jeff Liu
2014-06-17 15:21 ` Joerg Roedel
2014-06-17 19:24 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox