From: Dave Jones <davej@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: netdev@vger.kernel.org, ganesanr@broadcom.com
Subject: Re: MIPS: Add MSI support for XLP9XX
Date: Tue, 17 Jun 2014 20:18:37 -0400 [thread overview]
Message-ID: <20140618001837.GA24753@redhat.com> (raw)
In-Reply-To: <20140610013104.DF5A8660F61@gitolite.kernel.org>
On Tue, Jun 10, 2014 at 01:31:04AM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=d66f3f0e10b49df8d0cc0d8eb5bf2ef9863a33cf
> Commit: d66f3f0e10b49df8d0cc0d8eb5bf2ef9863a33cf
> Parent: 1c98398662c9b4e2f03f64344f83dd6cb14e0420
> Refname: refs/heads/master
> Author: Ganesan Ramalingam <ganesanr@broadcom.com>
> AuthorDate: Fri May 9 16:35:49 2014 +0530
> Committer: Ralf Baechle <ralf@linux-mips.org>
> CommitDate: Fri May 30 16:51:02 2014 +0200
>
> MIPS: Add MSI support for XLP9XX
...
> + if (cpu_is_xlp9xx()) {
> + val = ((node * nlm_threads_per_node()) << 7 |
> + PIC_PCIE_MSIX_IRQ(link) << 1 | 0 << 0);
Should this be..
val = ((node * nlm_threads_per_node()) << 7 |
PIC_PCIE_MSIX_IRQ(link) << 1);
val &= ~(1 << 0);
perhaps ? because shifting a zero is a nop, as is ORing it.
Dave
next parent reply other threads:[~2014-06-18 0:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140610013104.DF5A8660F61@gitolite.kernel.org>
2014-06-18 0:18 ` Dave Jones [this message]
2014-06-18 9:00 ` MIPS: Add MSI support for XLP9XX David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618001837.GA24753@redhat.com \
--to=davej@redhat.com \
--cc=ganesanr@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox