public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: linux-kernel@vger.kernel.org,
	Samuel Ortiz <sameo@linux.intel.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Shawn Guo <shawn.guo@freescale.com>
Subject: Re: [PATCH] mfd: mc13xxx: Use regmap irq framework for interrupts
Date: Wed, 18 Jun 2014 08:58:16 +0100	[thread overview]
Message-ID: <20140618075816.GL21030@lee--X1> (raw)
In-Reply-To: <1403062279.528598806@f152.i.mail.ru>

On Wed, 18 Jun 2014, Alexander Shiyan wrote:

> Tue, 17 Jun 2014 21:04:59 +0100 от Lee Jones <lee.jones@linaro.org>:
> > On Sat, 07 Jun 2014, Alexander Shiyan wrote:
> > 
> > > This patch convert mc13xxx MFD driver to use regmap irq framework
> > > for interrupt registration.
> > > 
> > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > > ---
> > >  drivers/mfd/Kconfig         |   1 +
> > >  drivers/mfd/mc13xxx-core.c  | 299 ++++++--------------------------------------
> > >  drivers/mfd/mc13xxx.h       |   7 +-
> > >  include/linux/mfd/mc13xxx.h |  21 +++-
> > >  4 files changed, 59 insertions(+), 269 deletions(-)
> > 
> > Patch looks good to me and I love the diffstat.  If any problems occur
> > as a result of applying this patch we can fix it up as subsequent
> > patch submissions.
> 
> Unfortunately, prolonged use of the modified version, revealed two errors.
> I will try to make incremental patch quickly, or can send a second version
> of the patch.

Very well, I'll yank the patch for now.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

      reply	other threads:[~2014-06-18  7:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-07  6:20 [PATCH] mfd: mc13xxx: Use regmap irq framework for interrupts Alexander Shiyan
2014-06-17 20:04 ` Lee Jones
2014-06-18  3:31   ` Alexander Shiyan
2014-06-18  7:58     ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140618075816.GL21030@lee--X1 \
    --to=lee.jones@linaro.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=shawn.guo@freescale.com \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox