From: Lee Jones <lee.jones@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: broonie@kernel.org, Andrew Bresticker <abrestic@chromium.org>,
swarren@wwwdotorg.org, olof@lixom.net,
Sonny Rao <sonnyrao@chromium.org>,
linux-samsung-soc@vger.kernel.org,
Prathyush K <prathyush.k@samsung.com>,
sameo@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: cros_ec_spi: set wakeup capability
Date: Wed, 18 Jun 2014 10:20:12 +0100 [thread overview]
Message-ID: <20140618092012.GF23945@lee--X1> (raw)
In-Reply-To: <1402953143-24681-1-git-send-email-dianders@chromium.org>
> From: Prathyush K <prathyush.k@samsung.com>
>
> Set the device as wakeup capable and register the wakeup source.
>
> Note: Though it makes more sense to have the SPI framework do this,
> (either via device tree or by board_info)
> this change is as per an existing mail chain:
> https://lkml.org/lkml/2009/8/27/291
>
> Signed-off-by: Prathyush K <prathyush.k@samsung.com>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> Note that I don't have suspend/resume actually working upstream, but I
> see that /sys/bus/spi/drivers/cros-ec-spi/spi2.0/power/wakeup exists
> with this patch and doesn't exist without it.
Very well. Applied, thanks.
> drivers/mfd/cros_ec_spi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
> index 0b8d328..ef22dd5 100644
> --- a/drivers/mfd/cros_ec_spi.c
> +++ b/drivers/mfd/cros_ec_spi.c
> @@ -385,6 +385,8 @@ static int cros_ec_spi_probe(struct spi_device *spi)
> return err;
> }
>
> + device_init_wakeup(&spi->dev, true);
> +
> return 0;
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-06-18 9:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 21:12 [PATCH] mfd: cros_ec_spi: set wakeup capability Doug Anderson
2014-06-18 9:20 ` Lee Jones [this message]
[not found] ` <CAD=FV=UiA=bsvune6A=wq+zKFq1+pkem0gTa-utxmBB6tKYM=A@mail.gmail.com>
2014-06-23 9:26 ` Lee Jones
2014-06-23 15:17 ` Doug Anderson
2014-06-27 0:28 ` Olof Johansson
2014-06-27 8:16 ` Lee Jones
2014-06-27 15:19 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618092012.GF23945@lee--X1 \
--to=lee.jones@linaro.org \
--cc=abrestic@chromium.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=prathyush.k@samsung.com \
--cc=sameo@linux.intel.com \
--cc=sonnyrao@chromium.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox