From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: "Petr Mládek" <pmladek@suse.cz>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
hpa@linux.intel.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, Michal Hocko <mhocko@suse.cz>,
Joe Perches <joe@perches.com>, Arun KS <arunks.linux@gmail.com>,
Kees Cook <keescook@chromium.org>,
Davidlohr Bueso <davidlohr@hp.com>,
Chris Metcalf <cmetcalf@tilera.com>
Subject: Re: [RFT v5h printk: allow increasing the ring buffer depending on the number of CPUs
Date: Wed, 18 Jun 2014 12:59:26 +0200 [thread overview]
Message-ID: <20140618105926.GL4841@wotan.suse.de> (raw)
In-Reply-To: <20140618083102.GF634@pathway.suse.cz>
On Wed, Jun 18, 2014 at 10:31:02AM +0200, Petr Mládek wrote:
> On Wed 2014-06-18 02:18:16, Luis R. Rodriguez wrote:
> I am happy with this solution. And I agree that it is better to split
> log_buf_len_align() in a separate patch as you suggested in the other
> mail.
OK just to be on safe side I noticed memblock_virt_alloc() and
memblock_virt_alloc_nopanic() allow passing an explicit alignment
requirement, traced back the orignal code with no good reason to
not use the LOG_ALIGN, so I think using that would be the safest
thing to do. Will roll that into the first patch, curious if the
folks that ran into the alignment issues on ARM could reproduce
an align barf without this on some situations, perhaps not because
of the power of 2 thing and since the min value for LOG_BUF_SHIFT
is 12.
Luis
next prev parent reply other threads:[~2014-06-18 10:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 0:37 [RFT v5h printk: allow increasing the ring buffer depending on the number of CPUs Luis R. Rodriguez
2014-06-17 14:52 ` Petr Mládek
2014-06-17 15:35 ` Petr Mládek
2014-06-17 16:33 ` Petr Mládek
2014-06-18 0:18 ` Luis R. Rodriguez
2014-06-18 4:12 ` Luis R. Rodriguez
2014-06-18 8:31 ` Petr Mládek
2014-06-18 10:59 ` Luis R. Rodriguez [this message]
2014-06-18 14:21 ` Petr Mládek
2014-06-18 18:31 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618105926.GL4841@wotan.suse.de \
--to=mcgrof@suse.com \
--cc=akpm@linux-foundation.org \
--cc=arunks.linux@gmail.com \
--cc=cmetcalf@tilera.com \
--cc=davidlohr@hp.com \
--cc=hpa@linux.intel.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=mhocko@suse.cz \
--cc=pmladek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox